[mythtv-commits] mythtv commit: r9646 - in trunk/mythtv by danielk

mythtv at cvs.mythtv.org mythtv at cvs.mythtv.org
Fri Apr 7 19:14:31 UTC 2006


      Author: danielk
        Date: 2006-04-07 19:14:30 +0000 (Fri, 07 Apr 2006)
New Revision: 9646
   Changeset: http://cvs.mythtv.org/trac/changeset/9646

Modified:

   trunk/mythtv/libs/libmyth/dbsettings.cpp
   trunk/mythtv/libs/libmyth/mythwizard.cpp
   trunk/mythtv/libs/libmyth/mythwizard.h
   trunk/mythtv/libs/libmyth/settings.cpp
   trunk/mythtv/libs/libmyth/settings.h
   trunk/mythtv/libs/libmythtv/channeleditor.cpp
   trunk/mythtv/libs/libmythtv/channelsettings.cpp
   trunk/mythtv/libs/libmythtv/dvbtransporteditor.cpp
   trunk/mythtv/libs/libmythtv/recordingprofile.cpp
   trunk/mythtv/libs/libmythtv/scanwizardhelpers.cpp
   trunk/mythtv/libs/libmythtv/scanwizardhelpers.h
   trunk/mythtv/libs/libmythtv/scanwizardscanner.cpp
   trunk/mythtv/libs/libmythtv/scheduledrecording.cpp
   trunk/mythtv/libs/libmythtv/videosource.cpp
   trunk/mythtv/programs/mythfrontend/globalsettings.cpp

Log:

This fixes some of the spacing problems using the *ConfigurationGroup's + adds a new as yet unused ConfigurationWizard.

I was working on a configuration wizard that would allow you to jump to a specific configuration pane when I realized there was a problem with how we initialize the ConfigurationGroup variables when inheriting from VerticalConfigurationGroup.

Since the ConfigurationGroup is virtually inherited in the VerticalConfigurationGroup we need to specifically initialize the ConfigurationGroup parent when inheriting from the VerticalConfigurationGroup, but very few classes were doing this, and instead were inheriting the default settings. Many of these classes then went ahead and reinitialized these variables to get rid of frames & labels.

I've also added a JumpConfigurationWizard, if you want to try it now, just replace ConfigurationWizard in globalsettings.h with JumpConfigurationWizard. But at the moment it uses buttons and is a bit ugly and klunky. The plan is to use a combobox to pick a pane to jump to, but this may requires some reorganization of the configuration panes which I'm still looking at.

We should not be virtually inheriting nor using multiple inheritence with classes that use Qt signals and slots, but I think this can only be fixed with a serious rewrite of the configuration code.






More information about the mythtv-commits mailing list