[mythtv-commits] Re: Ticket #617: Allow non-blocking client connections

[MythTV]

#617: Allow non-blocking client connections
-----------------------------+----------------------------------------------
 Reporter:  gnassas at mac.com  |        Owner:  gnassas at mac.com
     Type:  patch            |       Status:  closed         
 Priority:  minor            |    Milestone:  0.19           
Component:  mythtv           |      Version:  head           
 Severity:  medium           |   Resolution:  wontfix        
-----------------------------+----------------------------------------------
Comment (by gnassas at mac.com):

 {{{
 > But that extra argument to announce does exactly the
 > same thing as the block_shutdown/allow_shutdown commands.
 }}}

 Not true. The extra argument lets the BE know the nature of the connection
 '''before''' it clears the blockShutdown flag in Scheduler::RunScheduler.
 The code I'm looking at is this:

 {{{
             // we release the block when a client connects
             if (blockShutdown)
                 blockShutdown &= !m_mainServer->isClientConnected();
             else
             {
                 // find out, if we are currently recording (or LiveTV)
                 bool recording = false;
 }}}

 That flag is the key to blockSDWUwithoutClient and there's currently no
 way for mythwelcome to connect without clearing it. Once that happens the
 PC is coming down toot sweet unless someone intervenes.

 You're saying that somone is mythwelcome but, as I described in the
 earlier message, there's no possible way for it to figure out if the PC
 was brought up due to the power button, in which case it should block an
 idle shutdown, or due to WOL, in which case it's wrong to block as the BE
 should only stay up as long as the remote FE is connected.

 I won't play games with the reopen checkbox but I do hope this makes it
 in. For sure it's a problem and it'd be good to get it out of the way
 before a release and millions (dozens?) of people trip over it like me.

 - George

-- 
Ticket URL: <http://cvs.mythtv.org/trac/ticket/617>
MythTV <http://www.mythtv.org/>
MythTV