[mythtv-commits] Re: Ticket #545: SIGSEGV in mythfrontend when exiting a recording

[MythTV]

#545: SIGSEGV in mythfrontend when exiting a recording
------------------------------------+---------------------------------------
 Reporter:  hansi.urpils at gmail.com  |        Owner:  danielk
     Type:  defect                  |       Status:  new    
 Priority:  minor                   |    Milestone:  unknown
Component:  mythtv                  |      Version:  head   
 Severity:  medium                  |   Resolution:         
------------------------------------+---------------------------------------
Comment (by danielk):

 (In [7684]) Fixes #573. References #545.

 This fixes the problem of VSync syncing to the wrong screen in
 multiple screen configurations most of the time. If you span
 multiple screens, or move the window after it is initialized
 the sync may be off. I do create the OpenGL window in the center
 of the playback window, so if a just the edges of the window
 are on another screen, you are probably OK.

 As for the segfault, this probably fixes it. But since I can't
 reproduce it I can't be sure. It appears the problem was that
 Start()/WaitForFrame()/Stop() and the dtor of OpenGLVideoSync
 were not being called in the same thread. It looks like there
 was an earlier attempt to fix this by calling Stop() in the
 same thread as the destructor in tv_play, but this raced with
 the WaitForFrame() calls in the NVP thread. I've put the vsync
 delete in the NVP thread, which should solve the problem in
 altogether in non-error conditions. And, I've put a call to
 Stop() in the OpenGLVideoSync dtor, which should grab the
 OpenGL context just before it is used in the dtor.

-- 
Ticket URL: <http://cvs.mythtv.org/trac/ticket/545>
MythTV <http://www.mythtv.org/>
MythTV