[mythtv-commits] Re: Ticket #805: DB error (performing database upgrade) 1119 to 1120

[MythTV]

#805: DB error (performing database upgrade) 1119 to 1120
-----------------------+----------------------------------------------------
 Reporter:  anonymous  |        Owner:  bjm   
     Type:  defect     |       Status:  closed
 Priority:  minor      |    Milestone:        
Component:  mythtv     |      Version:        
 Severity:  medium     |   Resolution:  fixed 
-----------------------+----------------------------------------------------
Comment (by mythdev at penyball.cix.co.uk):

 I think some mysql versions don't support   update ... select ?
 I'm not sure what the group by was trying to do - the subselect would have
 returned multiple values if they existed anyway?

 Following is one approach - that doesn't try to do anything that the group
 by might have done.
 {{{
 Index: mythtv/libs/libmythtv/dbcheck.cpp
 ===================================================================
 --- mythtv/libs/libmythtv/dbcheck.cpp   (revision 8257)
 +++ mythtv/libs/libmythtv/dbcheck.cpp   (working copy)
 @@ -1957,12 +1957,12 @@
      {
          const QString updates[] = {
  "ALTER TABLE playgroup ADD COLUMN jump INT NOT NULL DEFAULT 0;",
 -"UPDATE playgroup SET jump = (SELECT data FROM settings"
 -"  WHERE value = 'JumpAmount' GROUP BY value) WHERE name = 'Default';",
 -"UPDATE playgroup SET skipahead = (SELECT data FROM settings"
 -"  WHERE value = 'FastForwardAmount' GROUP BY value) WHERE name =
 'Default';",
 -"UPDATE playgroup SET skipback = (SELECT data FROM settings"
 -"  WHERE value = 'RewindAmount' GROUP BY value) WHERE name = 'Default';",
 +"UPDATE playgroup, settings set playgroup.jump = settings.data"
 +" WHERE settings.value = 'JumpAmount' AND playgroup.name = 'Default';",
 +"UPDATE playgroup, settings set playgroup.skipahead = settings.data"
 +" WHERE settings.value = 'FastForwardAmount' AND playgroup.name =
 'Default';",
 +"UPDATE playgroup, settings set playgroup.skipback = settings.data"
 +" WHERE settings.value = 'RewindAmount' AND playgroup.name = 'Default';",
  ""
  };
          if (!performActualUpdate(updates, "1120", dbver))

 }}}

-- 
Ticket URL: <http://cvs.mythtv.org/trac/ticket/805>
MythTV <http://www.mythtv.org/>
MythTV