<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 12/16/23 10:46, Paul Harrison wrote:<br>
</div>
<blockquote type="cite"
cite="mid:059332dd-298c-4899-8f95-72e1aede0cca@mythqml.net">
<blockquote type="cite" style="color: #007cff;">
<blockquote type="cite" style="color: #007cff;">Option 3 - what
my commits do (although seemingly not on master)
<br>
<br>
If a video has no forced track then the player starts in
the
<br>
Off state. TOGGLECC toggles between Off and On.
<br>
<br>
If a video does have a forced track then the player starts
<br>
in the
<br>
Almost Off state. TOGGLECC toggles between Almost Off and On.
If you
<br>
want no subtitles at all, not even forced then you have to use
the
<br>
menu to and select "Disable forced subtitles", whereupon
TOGGLECC
<br>
will then toggle between Off and On.
<br>
<br>
In my opinion this is the optimal behaviour. It has more
complexity
<br>
in
<br>
the programming, but is actually easier to use. You can still
use
<br>
TOGGLECC to obtain the full subtitles at any time, when you
mishear
<br>
something, but you get the non-forced automatically which
you're
<br>
likely
<br>
to want because you don't understand Dothraki.
<br>
</blockquote>
I agree that this is the optimal behavior.
<br>
<br>
David
<br>
</blockquote>
<br>
<br>
Yep I agree with David this seems to be the way they should work.
Obviously if there are no subtitles or forced subtitles don't show
the option to turn them on in the menu's etc.
<br>
<br>
<br>
Paul H.
<br>
<br>
</blockquote>
<p>I tested the pull request
<a class="moz-txt-link-freetext" href="https://github.com/MythTV/mythtv/pull/821">https://github.com/MythTV/mythtv/pull/821</a> with master and it works
as described for Option 3 above.</p>
<p>I tested VLC and what it does is as follows: If there is a forced
track it enables it on start. From then onwards, toggle subtitles
(shift-V) enables or disables the forced track. If you select
another subtitle it disables the forced. In other words the forced
indicator only turns on the forced track at the start, after that
it has no effect. This is what MythTV does without the pull
request.<br>
</p>
<p>Another difference with VLC is if you have an external subtitle
file (srt file), it makes that a forced subtitle in preference to
the forced subtitle in the file. MythTV does not do this but it
does make the external subtitle the default if you toggle on.<br>
</p>
<p>Leanfront works like VLC, except it does not support external
subtitles (srt files) at this time.</p>
<p>Unless anybody objects, I will merge the pull request.</p>
<p>Peter<br>
</p>
<p><br>
</p>
</body>
</html>