<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Dec 18, 2013 at 1:25 PM, faginbagin <span dir="ltr"><<a href="mailto:mythtv@hbuus.com" target="_blank">mythtv@hbuus.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
On 12/17/2013 9:43 AM, Jim Stichnoth wrote:<br>
<div><div>> On Mon, Dec 16, 2013 at 9:06 PM, faginbagin <<a href="mailto:mythtv@hbuus.com" target="_blank">mythtv@hbuus.com</a> <mailto:<a href="mailto:mythtv@hbuus.com" target="_blank">mythtv@hbuus.com</a>>> wrote:<br>
><br>
> I'm getting ready to upgrade from 0.23 to 0.27 and in my testing I ran across an unexpected change in behavior. If I have a bookmark set or set a bookmark and then let playback continue to the end of the recording, the bookmark is cleared. This is a change from the way it was working in 0.23, where bookmarks were never cleared.<br>
><br>
> My bookmark related settings for both 0.23 and 0.27 are identical and are as follows:<br>
> General Playback (1/8)<br>
> Clear bookmark on playback Unchecked<br>
> Alternate clear and save bookmark Unchecked<br>
> General Playback (2/8)<br>
> Action on playback exit: Save position and exit<br>
> Prompt at end of recording Unchecked<br>
><br>
> Was this change in behavior deliberate? Is there some setting I can use to restore the old behavior? I was hoping to avoid having to compile my own, but if that's what is necessary to get back the old behavior, I will.<br>
><br>
> This was a deliberate change as of 0.26, due to <a href="http://code.mythtv.org/trac/ticket/7994" target="_blank">http://code.mythtv.org/trac/ticket/7994</a> . The consistency argument is documented in the ticket description.<br>
><br>
> If you want to change the behavior, look in TV::PrepareToExitPlayer(). You probably want to change the condition "if (bookmark_it)" to something like "if (bookmark_it && !(ctx->player->IsNearEnd() || getEndOfRecording()))".<br>
><br>
> Jim<br>
<br>
</div></div>Many thanks for the pointers, both the ticket and where to look to change the behavior.<br>
<br>
I have to say I disagree with the consistency argument, at least with the way it's working with my settings in 0.23. I see a clear distinction between the user actively choosing to exit playback by pressing Escape, as opposed to passively exiting playback because the recording played to the end, and don't see why the bookmark should be cleared in the passive exit case.<br>
<br>
I also feel that having it work the way it did in 0.23 is much more user friendly in a multi-person household where you don't want to clobber someone else's bookmark when you're able to watch a recording from beginning to end after they only found the time to watch part of the recording but want to resume where they left off.<br>
<br>
Another advantage to the old way is, if you're an insomniac who finds it easier to fall asleep to the TV than to silence, it's pretty darned convenient to press OK after you skip a commercial, knowing that, if you do fall asleep, you'll be able to resume watching the show from where you were last awake.<br>
<br></blockquote><div>Looking closer, I think maybe the auto-clear-bookmark logic is a bit too liberal. If "<span style="color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px">Clear bookmark on playback" is *unchecked* (which is true in your setup and not true in mine), perhaps the bookmark should be left alone at end-of-playback exit.</span></div>
<div><span style="color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px">Jim</span></div></div></div></div>