<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Dec 16, 2013 at 9:06 PM, faginbagin <span dir="ltr"><<a href="mailto:mythtv@hbuus.com" target="_blank">mythtv@hbuus.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
I'm getting ready to upgrade from 0.23 to 0.27 and in my testing I ran across an unexpected change in behavior. If I have a bookmark set or set a bookmark and then let playback continue to the end of the recording, the bookmark is cleared. This is a change from the way it was working in 0.23, where bookmarks were never cleared.<br>
<br>
My bookmark related settings for both 0.23 and 0.27 are identical and are as follows:<br>
General Playback (1/8)<br>
Clear bookmark on playback Unchecked<br>
Alternate clear and save bookmark Unchecked<br>
General Playback (2/8)<br>
Action on playback exit: Save position and exit<br>
Prompt at end of recording Unchecked<br>
<br>
Was this change in behavior deliberate? Is there some setting I can use to restore the old behavior? I was hoping to avoid having to compile my own, but if that's what is necessary to get back the old behavior, I will.<br>
<br></blockquote><div>This was a deliberate change as of 0.26, due to <a href="http://code.mythtv.org/trac/ticket/7994">http://code.mythtv.org/trac/ticket/7994</a> . The consistency argument is documented in the ticket description.</div>
<div><br></div><div>If you want to change the behavior, look in TV::PrepareToExitPlayer(). You probably want to change the condition "if (bookmark_it)" to something like "if (bookmark_it && !(ctx->player->IsNearEnd() || getEndOfRecording()))".</div>
</div><br></div><div class="gmail_extra">Jim</div></div>