<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Nov 5, 2013 at 5:05 PM, Karl Newman <span dir="ltr"><<a href="mailto:newmank1@asme.org" target="_blank">newmank1@asme.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div class="gmail_extra"><div class="gmail_quote">On Tue, Nov 5, 2013 at 4:34 PM, Paul Harrison <span dir="ltr"><<a href="mailto:mythtv@sky.com" target="_blank">mythtv@sky.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>On 06/11/13 00:05, Karl Newman wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
If the tags are id3 tags then it should find the images in them.<br>
If they are vorbis (Xiph) tags then we currently don't support<br>
reading the Picture blocks from them (taglib does appear to<br>
support them but nobody has updated our MetaIOFLACVorbis class to<br>
support them). Of cause patches are welcome :)<br>
<br>
<br>
I guess that's the issue. I probed the files some more and metaflac finds the tag info but id3 comes up blank. Is taglib used for the id3 tags as well? If so maybe it wouldn't be too difficult to patch that class since there's a pattern to follow...<br>
<br>
Karl<br>
<br>
</blockquote>
<br></div>
Yeah both id3 and the flac stuff both use taglib.<br>
<br>
You would need to add the virtual functions from virtual bool supportsEmbeddedImages(void) down to virtual QImage *getAlbumArt(const QString &filename, ImageType type) ( documented here :- <a href="http://code.mythtv.org/cgit/mythtv/tree/mythtv/libs/libmythmetadata/metaio.h#n46" target="_blank">http://code.mythtv.org/cgit/<u></u>mythtv/tree/mythtv/libs/<u></u>libmythmetadata/metaio.h#n46</a> ) into the MetaIOFLACVorbis class.<br>
<br>
You could use the ones in <a href="http://code.mythtv.org/cgit/mythtv/tree/mythtv/libs/libmythmetadata/metaioid3.cpp#n348" target="_blank">http://code.mythtv.org/cgit/<u></u>mythtv/tree/mythtv/libs/<u></u>libmythmetadata/metaioid3.cpp#<u></u>n348</a> as an example.<div>
<div><br>
<br>
Paul H.<br></div></div></blockquote></div><br></div></div><div class="gmail_extra">Yep, I found that. It doesn't look too bad; I'll see what I can knock together.<span><font color="#888888"><br><br>
Karl<br></font></span></div></div>
</blockquote></div><br></div><div class="gmail_extra">Paul,<br><br></div><div class="gmail_extra">I created the attached patch. It compiles, but when I scan for new music (after touch-ing some flac files which had embedded art), no art is detected (also tried manually editing the album art for the file). I think my flac files have a vestigial id3 tag, so I modified the tagger
factory in metaio.cpp to always return a MetaIOFLACVorbis object. Still
no luck, though. I'm not set up for debugging at all, so I don't even know if it's hitting my code paths. Any chance you could you test it out and let me know what's going on?<br>
<br></div><div class="gmail_extra">Thanks,<br><br>Karl<br></div></div>