<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On 16 April 2013 17:52, Paul Gardiner <span dir="ltr"><<a href="mailto:lists@glidos.net" target="_blank">lists@glidos.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
I meant, rather than a change in the code, that the driver was causing<br>
GetVideoModes to return fresh objects (perhaps because GetVideoModes<br>
used a cache and the driver was returning constantly altering info<br>
that caused cache misses - something like that). In any case, I'm<br>
mistaken, but the fact remains that it does fix the problem, whatever<br>
the cause might be.<br></blockquote><div><br></div><div>Nah.. did you actually have a look at the code?<br></div><div>Changing:<br><table class=""><tbody><tr class="" id="mythtv-libs-libmythui-displayres-cpp-P26"><td class="">
- bool chg = !(next == m_last) ||
</td>
</tr>
<tr class="" id="mythtv-libs-libmythui-displayres-cpp-P27">
<td class="">
+ bool chg = !(next.Width() == m_last.Width()) ||
</td>
</tr>
<tr class="" id="mythtv-libs-libmythui-displayres-cpp-P28">
<td class="">
+ !(next.Height() == m_last.Height()) ||
</td>
</tr>
<tr class="" id="mythtv-libs-libmythui-displayres-cpp-P29">
<td class="">
<br></td></tr></tbody></table>is totally useless<br><br></div><div>next and m_last are instances of DisplayResScreen. It overrides the == operator with:<br>inline bool DisplayResScreen::operator == (const DisplayResScreen &b) const<br>
{<br> return width == b.width && height == b.height;<br>} <br><br></div><div>The patch overall is very non-elegant, it brakes totally the MV approach, changing the list of modes and overriding it.<br><br></div>
<div>The only thing that is actually doing something is that bit:<br><table class=""><tbody><tr class="" id="mythtv-libs-libmythui-displayres-cpp-P51"><td class="">+ next.ClearRefreshRates();
</td>
</tr>
<tr class="" id="mythtv-libs-libmythui-displayres-cpp-P52">
<td class="">
+ next.AddRefreshRate(target_rate);
</td>
</tr>
<tr class="" id="mythtv-libs-libmythui-displayres-cpp-P53">
<td class="">
<br></td></tr></tbody></table>it pretty much discard everything done above and force only one refresh rate to be used...<br><br></div><div>That's just not the way to do it.<br><br></div><div>Now if I could reproduce the issue you are seeing, I will definitely have a shot at it... but the particular patch you're using is certainly not the way to do it.<br>
</div><div><pre><br></pre></div><div><br></div><div> </div></div></div></div>