[mythtv-users] Help merging MythGallery feature

Chad Parry spam at chad.parry.org
Sat Jan 10 04:05:23 UTC 2015


On 01/03/2015 10:26 AM, Chad Parry wrote:
>> On Sat, 03 Jan 2015 03:49:14 -0000, Chad Parry <spam at chad.parry.org  <http://lists.mythtv.org/mailman/listinfo/mythtv-users>> wrote:
>>> /I created a pull request more than 6 months ago:
>>> //https://github.com/MythTV/mythtv/pull/75.  It drastically improves the
>>> //start-up time for large slide shows. I also have another pull request
>>> //for a separate feature that is blocked on this one. My code conforms to
>>> //the standards and just needs someone to merge it. Can someone please
>>> //accept it? Thanks!/
>>
>> The MythGallery plugin is currently deprecated because it uses the old UI.
>> The plan is to replace it with the "New Image Gallery" in 0.28 that uses
>> the new UI as well as Storage Groups and can support a services API. I'm
>> working on this at the moment but haven't yet finalised a version for
>> review. Master currently contains a incomplete version that doesn't work
>> very well.
>>
>> Of course, the new Gallery doesn't preclude the continued use of the old
>> plugin. However,
>> I notice that some of the old UI has been deprecated so it may not
>> function if/when that is removed.
>>
>> A cursory look at your patch suggests that the old plugin took a long time
>> to generate thumbnails before starting the slideshow. This isn't an issue
>> with the new design as the thumbnails are pre-generated. I haven't seen
>> your 2nd pull.
>> What issues/features does that address ?
> Thanks for the info. I'd be happy to help merge these features into 
> the new UI if that would be useful.
>
> The reason I made the first patch is because it took a long time to 
> recursively traverse directories and find all the photos. I noticed it 
> because I have thousands of NFS-mounted photos. This may still be an 
> issue in the new UI, unless there is also fast lookup in the database. 
> The issue is exacerbated by my second feature, because it reads EXIF 
> data from all the photos during the preparation stage.
>
> The second feature is a "seasonal slideshow," 
> (https://code.mythtv.org/trac/ticket/12335). It was really fun to have 
> enabled at my house over the holidays. It's like the random slideshow, 
> except with a much larger weight assigned to photos taken at the same 
> time of year. Near Christmas you get more Christmas photos, and near 
> birthdays you get more birthday photos.
Ping! Roger, can you accept my pull request, 
(https://github.com/MythTV/mythtv/pull/75)? Or does anyone know who can?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-users/attachments/20150109/dd8dcfa1/attachment.html>


More information about the mythtv-users mailing list