[mythtv-users] DVD Bookmark support?

Richard Hulme peper03 at yahoo.com
Thu Jan 16 21:35:38 UTC 2014


On 15/01/14 23:16, Tom Dexter wrote:
> On Wed, Jan 15, 2014 at 2:25 PM, Richard Hulme <peper03 at yahoo.com> wrote:
>> Tom Dexter <digitalaudiorock at gmail.com> wrote:
>>>
>>> On Mon, Jan 13, 2014 at 5:07 PM, Richard Hulme <peper03 at yahoo.com> wrote:
>>>>
>>>> On 25/12/13 19:19, Tom Dexter wrote:
>>>>
>>>>
>>>> Hi,
>>>>
>>>> Ok, bookmarks for VIDEO_TS directories were not explicitly disabled and
>>>> there is/was no bug in libdvdread.
>>>>
>>>> The problem was simply that DVD bookmarks are stored in the database
>>>> using
>>>> the DVD's serial number as the key.  libdvdread does not return a serial
>>>> number for directories as there *is* no serial number.
>>>>
>>>> If there's no serial number, we don't try to store a bookmark (which is
>>>> probably the 'disabled for directories' bit).
>>>>
>>>> Anyway, I added some code to detect that case and generate a serial
>>>> number
>>>> by calculating the CRC of one of the files.  That should be good enough.
>>>>
>>>> If you want to try it, either sync to the latest master or try applying:
>>>>
>>>> https://github.com/MythTV/mythtv/commit/70143d3.patch
>>>>
>>>> I haven't tried it on 0.27, but I guess it would work.
>>>>
>>>> Richard.
>>>
>>>
>>> Great!  That patch appears to at least cleanly apply to the current
>>> 0.27 version I'm using under Gentoo.  I'll give it a try.  I'm
>>> assuming that patch would be needed on both the frontend and backend?
>>>
>>> Thanks!
>>> Tom
>>
>>
>> Hi,
>>
>> The backend isn't involved in playback so it's enough just to update the
>> frontend.
>>
>> Richard
>>
>
> Cool!  That patch worked great on the current Gentoo version of 0.27
> (media-tv/mythtv-0.27_p20131124).  Your timing couldn't have been
> better as I needed to recompile mythtv today for a perl version
> update.

Great!

> I had already put that patch on both the back and front...I'll keep in
> mind that I really don't need it on the backend.  Thanks again!  Great
> stuff.

It won't have any negative effects in the backend, it just won't get used.

Glad I could help!

Richard.


More information about the mythtv-users mailing list