[mythtv-users] Archive to DVD - time format error

[John Pilkington]

On 18/11/13 19:59, Zig wrote:
> On 11/17/2013 5:29 AM, Paul Harrison wrote:
>> On 17/11/13 10:17, John Pilkington wrote:
>>>
>>> However, I have a confession to make.  My instructions for patching
>>> mythburn.py were incomplete; they didn't follow RW's patch. Try that.
>>>
>>> http://code.mythtv.org/trac/ticket/11758#comment:2
>>>
>>
>> I've committed the patch to both master and fixes to make it easier to
>> test.
>>
>> Please report back if it fixed the problem for you.
>>
>> Thanks,
>>
>> Paul H.
>>
> Hi Paul, I'm now running v0.27-93-gb0c1c97.  I still get the same error,
> mythtranscode cannot find the recording.  If I patch the new mythburn.py
> with this patch it works fine:
> ______________________________________________
> --- mythburn.py    2013-09-23 18:09:40.000000000 -0500
> +++ mythburn.py.zig    2013-09-26 07:50:53.479406824 -0500
> @@ -1426,7 +1426,7 @@
>           data.description    = rec.description
>           data.rating         = str(rec.stars)
>           data.chanid         = rec.chanid
> -        data.starttime      = rec.starttime.isoformat()
> +        data.starttime      = rec.starttime.utcisoformat()
>
>           cutlist = rec.markup.getcutlist()
>           if len(cutlist):
> ______________________________________________
> I also put in the following patch which writes to the log file, to see
> how mythtranscode was being called during a successful run:
> ***********************************************************************
> --- mythburn.py    2013-09-26 08:29:36.864946340 -0500
> +++ mythburn.py.logCommand    2013-10-12 09:15:08.081108196 -0500
> @@ -1755,6 +1755,9 @@
>           write("Failed while running mythtranscode to cut commercials
> and/or clean up an mpeg2 file.\n"
>                 "Result: %d, Command was %s" % (result, command))
>           return False;
> +    else:
> +        write("Successful run of mythtranscode to cut commercials
> and/or clean up an mpeg2 file.\n"
> +              "Result: %d, Command was %s" % (result, command))
>
>       return True
> **********************************************************************
>
> This is the desired file to be processed:
> Processing recording 1: '/var/lib/mythtv/recordings/1571_20131117160300.mpg'
>
> This is the mythtranscode command line generated by the current
> unpatched mythburn.py which fails:
> mythtranscode --mpeg2 --chanid 1571 --starttime
> 2013-11-17T10:03:00-06:00 --outfile
> "/var/lib/mytharchive/temp/work/1/newfile.mpg"
>
> This is the mythtranscode command line generated after applying the
> first patch listed above which then succeeds:
> mythtranscode --mpeg2 --chanid 1571 --starttime 2013-11-17T16:03:00
> --outfile "/var/lib/mytharchive/temp/work/1/newfile.mpg"
>
> In the case of failure, mythtranscode does not understand time zone
> offsets.  After applying the patch, the timezone offset is computed into
> the the starttime before it is handed to mythtranscode.
>
> As an aside, the new mythburn.py (92) is different from the old
> mythburn.py (pre 92) but the version number in the mythburn.py file has
> stayed the same.  So that's a bit confusing.
>
> Thanks for looking into  this,
> Ziggy
>

Updating the version tag is a bit of a chore and is easily overlooked, 
but yes, it's confusing.

I still feel that many of the entries in the progress log are more like 
tourist commentary than diagnostic aids; they rely on getting back a 
status code from a process whose failure may be the only reason for 
looking at the log.  /Please/ log details of the call before issuing it 
if problems may arise.

And Ziggy:  the details of your patch-that-works are quite likely to be 
overlooked if you post them only on the users list.  Trac tickets are, 
at least in principle, reviewed eventually.  That's why I copied it 
there when you first reported it.

Cheers,

John