[mythtv-users] Album art in MythMusic

Karl Newman newmank1 at asme.org
Sat Nov 9 06:17:44 UTC 2013


On Tue, Nov 5, 2013 at 5:05 PM, Karl Newman <newmank1 at asme.org> wrote:

> On Tue, Nov 5, 2013 at 4:34 PM, Paul Harrison <mythtv at sky.com> wrote:
>
>> On 06/11/13 00:05, Karl Newman wrote:
>>
>>>
>>>
>>>     If the tags are id3 tags then it should find the images in them.
>>>     If they are vorbis (Xiph) tags then we currently don't support
>>>     reading the Picture blocks from them (taglib does appear to
>>>     support them but nobody has updated our MetaIOFLACVorbis class to
>>>     support them). Of cause patches are welcome :)
>>>
>>>
>>> I guess that's the issue. I probed the files some more and metaflac
>>> finds the tag info but id3 comes up blank. Is taglib used for the id3 tags
>>> as well? If so maybe it wouldn't be too difficult to patch that class since
>>> there's a pattern to follow...
>>>
>>> Karl
>>>
>>>
>> Yeah both id3 and the flac stuff both use taglib.
>>
>> You would need to add the virtual functions from virtual bool
>> supportsEmbeddedImages(void) down to virtual QImage *getAlbumArt(const
>> QString &filename, ImageType type) ( documented here :-
>> http://code.mythtv.org/cgit/mythtv/tree/mythtv/libs/
>> libmythmetadata/metaio.h#n46 ) into the MetaIOFLACVorbis class.
>>
>> You could use the ones in http://code.mythtv.org/cgit/
>> mythtv/tree/mythtv/libs/libmythmetadata/metaioid3.cpp#n348 as an example.
>>
>>
>> Paul H.
>>
>
> Yep, I found that. It doesn't look too bad; I'll see what I can knock
> together.
>
> Karl
>

Paul,

I created the attached patch. It compiles, but when I scan for new music
(after touch-ing some flac files which had embedded art), no art is
detected (also tried manually editing the album art for the file). I think
my flac files have a vestigial id3 tag, so I modified the tagger factory in
metaio.cpp to always return a MetaIOFLACVorbis object. Still no luck,
though. I'm not set up for debugging at all, so I don't even know if it's
hitting my code paths. Any chance you could you test it out and let me know
what's going on?

Thanks,

Karl
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mythtv.org/pipermail/mythtv-users/attachments/20131108/28636ff9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flac_embedded_art.patch
Type: application/octet-stream
Size: 12606 bytes
Desc: not available
URL: <http://www.mythtv.org/pipermail/mythtv-users/attachments/20131108/28636ff9/attachment.obj>


More information about the mythtv-users mailing list