[mythtv-users] new yellow highlight for recordings in master

[John P Poet]

On Thu, Dec 15, 2011 at 2:12 PM, Brian J. Murrell <brian at interlinx.bc.ca>wrote:

> On 11-12-15 03:39 PM, Brian J. Murrell wrote:
> >
> > Hrm.  I wonder what's "damaged" about every single recording I have done
> > since upgrading on Sunday evening then.  They all certainly look fine.
>
> And having a (first real, in fact) look at the backend logs since
> upgrading I can see:
>
> 2011-12-15 00:30:01.842022 I [5583/5594] TVRecEvent tv_rec.cpp:811
> (FinishedRecording) - TVRec::FinishedRecording(Saturday Night Live) good
> recq:<RecordingQuality overall_score="1" key="4111_2011-12-14T23:30:00"
> countinuity_error_count="37" packet_count="7234892">
>    <Gap start="2011-12-14T23:48:39" end="2011-12-14T23:48:39" duration="0"
> />
> </RecordingQuality>
>
> Anyone care to comment on what all of that means?
>
> As an aside, does any of this recording quality metrics affect the
> scheduler yet?  i.e. if a recording is considered damaged, will it be
> rescheduled and recorded, ideally at a lower priority than anything
> that has not yet been recorded?  And without overwriting the existing
> recording until it can be determined that it was better quality?
>
> Cheers,
> b.
>

Yeah, there was a little bit of debugging left in that commit.

Look for:

((is_good&&false) ? 0 : VID_DAMAGED))

and change that to

(is_good ? 0 : VID_DAMAGED))



John
-- 
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.mythtv.org/pipermail/mythtv-users/attachments/20111215/90e85ef3/attachment.html