[mythtv-users] LIRC and MythBuntu 10.10

Mark Lord mythtv at rtr.ca
Fri Apr 15 13:30:00 UTC 2011


On 11-04-15 09:25 AM, Mark Lord wrote:
>
> The lirc_serial in many kernels was never tested before release,
> and has a nasty bug that prevents it from working.
> Fortunately, the fix is rather simple:
> 
> --- b0rked/drivers/staging/lirc/lirc_serial.c        2011-01-04
> 19:50:19.000000000 -0500
> +++ linux/drivers/staging/lirc/lirc_serial.c    2011-02-06 15:33:49.854453928 -0500
> @@ -966,7 +966,7 @@
>         if (n % sizeof(int) || count % 2 == 0)
>                 return -EINVAL;
>         wbuf = memdup_user(buf, n);
> -       if (PTR_ERR(wbuf))
> +       if (IS_ERR(wbuf))
>                 return PTR_ERR(wbuf);
>         spin_lock_irqsave(&hardware[type].lock, flags);
>         if (type == LIRC_IRDEO) {
> -----
> 
> If that fix is not already in Ubuntu-10.10, then you should probably
> pursue the Ubuntu kernel maintainers and try to get it added there.

Note that there are also memory leaks in those same b0rked versions
of lirc_serial and pals, and there is a more comprehensive patch
available to take care of those as well as the fix above.


More information about the mythtv-users mailing list