[mythtv-users] Program Info Flag for Preserve Episode

[Richard Freeman]

I use the preserve episode feature quite a bit (tend to record shows
that end up with a mix of shows I do and don't want to see, but they're
on often enough that I want to set an episode limit so as to not flood
my storage with the show).  I've been a bit annoyed by the fact that
there is no indication on-screen as to whether this flag is set for any
particular episode (auto-expire is flagged, but preserve is not).

I put this on the feature wishlist, but then I figured something like
this ought to be easy enough to write up as a patch in the spirit of
giving back (I'm sure the devs have better things to worry about).

Here I'm a bit limited by a lack of artistic creativity: what should the
preserved icon look like?  If somebody wants to send me a .png or any
ideas feel free.

Otherwise I think all I need to do is:

Patch playbackbox.cpp where the flags are displayed to add a flag for
the preserve flag.

Patch programinfo.cpp to fetch the flag in the DB query and add it to
the programflags variable.

Patch programinfo.h to add a mask for the new flag.

Patch ui.xml to add an icon and position for the new flag.

I didn't spend much time reverse engineering UITypes so I'm assuming
that if I put the icon in the xml it will be retrievable using
UIImageType.GetType with the appropriate alias.

Anybody see any glaring omissions here (especially on the UI side - I
didn't spend much time tracing this code).  Anybody have strong thoughts
one way or another on this getting accepted by the dev team?  Any ideas
regarding what the preserve icon should look like?  I probably could
draw something up in gimp but I'm not super-creative in this arena.
Actually, if there are any theme gurus out there you might just want to
do this yourselves...  :)