[mythtv-firehose] mythtv branch master updated by stuartm. v0.28-pre-1587-g5299102

Git Repo Owner noreply at mythtv.org
Mon Jun 9 18:41:58 UTC 2014


The branch, master has been updated on the
mythtv repository by gitolite user stuartm.
       via  5299102a950f24306d6637c2b5134afb71265700 (commit)
       via  e82554fb85e5fb6a9ac0a1037dc688966cbc91a9 (commit)
       via  21caaa4beb746593df9744407f09f90e6394ea47 (commit)
      from  18511f814933c5f4494f4afd97f159ef2e3bdeed (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5299102a950f24306d6637c2b5134afb71265700
Author:    Stuart Morgan <smorgan at mythtv.org> at Mon, 9 Jun 2014 19:25:25 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Mon, 9 Jun 2014 19:26:54 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=5299102a950f24306d6637c2b5134afb71265700

Add the approximate query execution time to the database query logging.



commit e82554fb85e5fb6a9ac0a1037dc688966cbc91a9
Author:    Stuart Morgan <smorgan at mythtv.org> at Mon, 9 Jun 2014 13:24:29 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Mon, 9 Jun 2014 13:24:29 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=e82554fb85e5fb6a9ac0a1037dc688966cbc91a9

Services API: Remove useless GROUP BY clauses from GetProgramList and GetProgramGuide. This speeds them up, significantly in the case of GetProgramList.



commit 21caaa4beb746593df9744407f09f90e6394ea47
Author:    Stuart Morgan <smorgan at mythtv.org> at Mon, 9 Jun 2014 12:47:42 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Mon, 9 Jun 2014 13:06:30 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=21caaa4beb746593df9744407f09f90e6394ea47

ProgramInfo::LoadFromProgram: Move the query 'fixups' out of FromProgramQuery
These fixups should ultimately be rethought or removed, they append
WHERE, GROUP BY or ORDER BY clauses to the end of the sql whether or
not it that's syntactically correct. More to the point however they
alter the query from what was requested by the caller in a
non-transparent way. A complete rethink of LoadFromProgram() is
probably required, where instead of passing in raw SQL there are more
arguments to the method to control it's output.

We don't want to use GROUP BY in combination with LIMIT or OFFSET as
this causes the query to take as long as it would without the
LIMITS. For the program table that can mean it takes 10 times longer
than it otherwise would. It's faster to filter out any duplicates when
iterating over the result set.



-----------------------------------------------------------------------

Summary of changes:
 mythtv/libs/libmyth/programinfo.cpp            |   96 ++++++++++++++----------
 mythtv/libs/libmythbase/mythdbcon.cpp          |   12 +++-
 mythtv/programs/mythbackend/services/guide.cpp |    7 --
 3 files changed, 66 insertions(+), 49 deletions(-)

-- 



More information about the mythtv-firehose mailing list