[mythtv-firehose] mythtv branch master updated by stuartm. v0.27-beta-128-gd441bdf

Git Repo Owner noreply at mythtv.org
Sun Sep 1 12:20:37 UTC 2013


The branch, master has been updated on the
mythtv repository by gitolite user stuartm.
       via  d441bdf5a083e27e7def6a7c0ac205e071e63c45 (commit)
       via  9406c5ba7589c3317257ed954e1e0a5442ba31e8 (commit)
      from  c4a75d88dc1f0053199da98fce45cc4c937a7170 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d441bdf5a083e27e7def6a7c0ac205e071e63c45
Author:    Sascha Hinck <SHinck at web.de> at Sat, 6 Jul 2013 01:48:43 +0200
Committer: Stuart Morgan <smorgan at mythtv.org> at Sun, 1 Sep 2013 13:17:01 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=d441bdf5a083e27e7def6a7c0ac205e071e63c45

Fix Memory Leak in DVXA
According to Microsoft MSDN The CreateSurface? method also adds reference counts to the surface buffers:
 "The method fills the array with IDirect3DSurface9 pointers. The caller must release all of the interface pointers. In addition, the front buffer holds a reference count on each of the back buffers. Therefore, the back buffers are never deleted until the front buffer is deleted."

So I eliminated the additional add of reference counts to all the buffers because this would lead to a Memory leak because our code releases this buffers only once.

Additionally I designed the release of this buffers as SafeRelease? which is recommended by Microsoft:
{{{
Checks whether the pointer is NULL.
Calls Release if the pointer is not NULL.
Sets the pointer to NULL.
}}}

Refs #11652

Signed-off-by: Stuart Morgan <smorgan at mythtv.org>



commit 9406c5ba7589c3317257ed954e1e0a5442ba31e8
Author:    Sascha Hinck <SHinck at web.de> at Sat, 6 Jul 2013 01:48:43 +0200
Committer: Stuart Morgan <smorgan at mythtv.org> at Sun, 1 Sep 2013 13:09:46 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=9406c5ba7589c3317257ed954e1e0a5442ba31e8

Fix segfaulting with DXVA2 hardware decoding at player end
If playing content with DXVA2 hardware decoding mythfrontend segfaults
on player end. That's because IDirectXVideoDecoderService_CreateSurface
creates surface_count + 1 surfaces (1 frontbuffer + surface_count
backbuffers) but IDirectXVideoDecoderService_CreateDecoder is created with
surface_count buffers.

Refs #11652

Signed-off-by: Stuart Morgan <smorgan at mythtv.org>



-----------------------------------------------------------------------

Summary of changes:
 mythtv/libs/libmythtv/dxva2decoder.cpp |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

-- 



More information about the mythtv-firehose mailing list