[mythtv-firehose] mythtv branch master updated by stuartm. v0.27-pre2-1250-gb578a5e

Git Repo Owner noreply at mythtv.org
Tue Jun 4 21:23:41 UTC 2013


The branch, master has been updated on the
mythtv repository by gitolite user stuartm.
       via  b578a5e6444ee5d04c00387d233ab79ddba691a3 (commit)
       via  c6ffdf44acb5238d7a1fe1a0b9713ea98e8b8159 (commit)
       via  b1d6e4bef471c8cee39bdc5e644d4e8351f616e0 (commit)
       via  63687f832a105956e8e070306cc81d85b5f9945e (commit)
      from  e60495b73879452255f707e47630b172941e5d0d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b578a5e6444ee5d04c00387d233ab79ddba691a3
Author:    Gary Buhrmaster <gary.buhrmaster at gmail.com> at Mon, 27 May 2013 15:15:22 +0000
Committer: Stuart Morgan <smorgan at mythtv.org> at Tue, 4 Jun 2013 22:22:50 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=b578a5e6444ee5d04c00387d233ab79ddba691a3

Check the return code from setsockopt (in lirc.cpp)
Static analysis (coverity) identified that the return code
from setsockopt was not checked.  This patch checks the
return code, with a log message if the setting fails.
(cherry picked from commit 0ae45b8598110898f4779f3bdc826e1ce5abb005)

Signed-off-by: Stuart Morgan <smorgan at mythtv.org>

Fixes #11550



commit c6ffdf44acb5238d7a1fe1a0b9713ea98e8b8159
Author:    Gary Buhrmaster <gary.buhrmaster at gmail.com> at Sun, 26 May 2013 22:45:02 +0000
Committer: Stuart Morgan <smorgan at mythtv.org> at Tue, 4 Jun 2013 22:21:29 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=c6ffdf44acb5238d7a1fe1a0b9713ea98e8b8159

Fix static analysis detected use without assignment
In ClassicCommDetector.cpp, static analysis indicates that
the variable currentFrameNumber could be used without
previously assigning it a value if certain code feasible
code paths are taken.  Assign it the value 0 at declaration.
(cherry picked from commit d2a021c29cf7d8bb4c13dd340654e61b4a16c8da)

Signed-off-by: Stuart Morgan <smorgan at mythtv.org>

Fixes #11552



commit b1d6e4bef471c8cee39bdc5e644d4e8351f616e0
Author:    Gary Buhrmaster <gary.buhrmaster at gmail.com> at Mon, 27 May 2013 00:27:08 +0000
Committer: Stuart Morgan <smorgan at mythtv.org> at Tue, 4 Jun 2013 22:20:22 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=b1d6e4bef471c8cee39bdc5e644d4e8351f616e0

Patch for (potential) uninitalized variable num_lines
Static analysis indicates that there is a feasible
code path in LayoutParagraphs (called in GetNarrowWidth)
which will not result in calling Layout which will
initialize the variable num_lines.  Initialize the
variable num_lines just in case (and make the
analyzer happy).
(cherry picked from commit a5388fb30e8fce9b8875563d3b1382a2888fcc2c)

Signed-off-by: Stuart Morgan <smorgan at mythtv.org>

Fixes #11553



commit 63687f832a105956e8e070306cc81d85b5f9945e
Author:    Gary Buhrmaster <gary.buhrmaster at gmail.com> at Tue, 28 May 2013 01:55:28 +0000
Committer: Stuart Morgan <smorgan at mythtv.org> at Tue, 4 Jun 2013 22:15:26 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=63687f832a105956e8e070306cc81d85b5f9945e

Fix use after free (realloc) in ParseText.cpp
Static analysis detected a use after free (realloc).  The
member variable should use the new string address, and it
is assigned the new string address after the usage.  This
looks to be a copy/paste error sometime in the past.  In
addition, follow the stated convention and null terminate
the string, just in case.
(cherry picked from commit df4aef6acf73e31f6399ce4c30c2d508e26c72a1)

Signed-off-by: Stuart Morgan <smorgan at mythtv.org>

Fixes #11556



-----------------------------------------------------------------------

Summary of changes:
 mythtv/libs/libmythfreemheg/ParseText.cpp          |    3 ++-
 mythtv/libs/libmythui/lirc.cpp                     |   16 ++++++++++++++--
 mythtv/libs/libmythui/mythuitext.cpp               |    3 ++-
 .../programs/mythcommflag/ClassicCommDetector.cpp  |    2 +-
 4 files changed, 19 insertions(+), 5 deletions(-)

-- 



More information about the mythtv-firehose mailing list