[mythtv-firehose] mythtv/master commit: 098ead81b by Chris Pinkham (cpinkham)

MythTV noreply at mythtv.org
Sun Oct 23 03:12:46 UTC 2011

      Author:  Chris Pinkham <cpinkham at mythtv.org>
 Change Date:  2011-10-22T20:05:00-07:00
   Push Date:  2011/10/22 20:12:33 -0700
  Repository:  mythtv
      Branch:  master
New Revision:  098ead81b8c75f596b128d5830ecbb8ae10a83e9
   Changeset:  https://github.com/MythTV/mythtv/commit/098ead81b


Fix potential segfault in MythUI teardown.

When the main screen stack is deleted, NULL out the pointer
tracking it in MythMainWindowPrivate.

In MythScreenStack::PopScreen(), check that the pointer
returned by MythMainWindow::GetMainStack() is non-NULL before trying
to use it to check the top screen on the main stack.

I believe this cures the segfault reported in IRC by several people
that occurred in QRect::width() when called by MythUIType::SetRedraw()
from MythScreenStack::PopScreen().  It was hard to get decent debugging
output on this, but it appears we were trying to access the already-
deleted main screen stack when deleting the background screen stack.



More information about the mythtv-firehose mailing list