[mythtv-firehose] mythtv/master commit: 83e3c5ebc by Gavin Hurlbut (Beirdo)

MythTV noreply at mythtv.org
Mon Jul 25 06:55:17 UTC 2011

      Author:  Gavin Hurlbut <ghurlbut at mythtv.org>
 Change Date:  2011-07-24T23:51:00-07:00
   Push Date:  2011/07/24 23:55:06 -0700
  Repository:  mythtv
      Branch:  master
New Revision:  83e3c5ebc475a28ece668111ec13dacf0d80fe1d
   Changeset:  https://github.com/MythTV/mythtv/commit/83e3c5ebc


Rework LIRC::GetCodes() to simplify buffer usage

Fixes #9246

This started as a fix for a valgrind-found branch based on uninitialized data.
As I was in there trying to make it not be branching based on the last
character after expanding the buffer, I simplified the algorithm as well.

Now, we resize the buffer to hold 128 new bytes just before doing the read,
and always read up to 128 bytes.  Instead of resizing after, I changed it to
a truncate, and use takeLast() rather than back() and pop_back() on the
returned list.



More information about the mythtv-firehose mailing list