<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
On 11/24/22 06:46, John Hoyt wrote:<br>
<blockquote type="cite"
cite="mid:CAE8sghThC+1MJ5xuDQ=FUwWDMPFqM2O3a8Uw_rv-qCaTM73ZDw@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr"><br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Nov 23, 2022 at 7:18
PM Scott Theisen <<a
href="mailto:scott.the.elm@gmail.com"
moz-do-not-send="true" class="moz-txt-link-freetext">scott.the.elm@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div> On 11/23/22 18:37, John Hoyt wrote:<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Nov 23,
2022 at 6:28 PM John Hoyt <<a
href="mailto:john.hoyt@gmail.com"
target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">john.hoyt@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px
0px 0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div class="gmail_quote">
<div>Hi Scott, thanks for taking a look. I've
worked up a patch file to resolve, but it
sounds like getting configure working
correctly is a better solution (happy to
post the patch file).</div>
<div> </div>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>Without the outputs from configure,
particularly the log file config.ep, I
can't say for certain if those lines are
the problem.<br>
</div>
</blockquote>
<div><br>
</div>
<div>Configure output: <a
href="https://pastebin.com/gG8E1Fbg"
target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">https://pastebin.com/gG8E1Fbg</a></div>
<div>config.ep: <a
href="https://pastebin.com/b6Tk5M4Q"
target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">https://pastebin.com/b6Tk5M4Q</a></div>
</div>
</div>
</blockquote>
<div><br>
</div>
</div>
</div>
</blockquote>
<br>
from config.ep line 5736:<br>
```<br>
<div>dyld[67989]: Library not loaded:
'@PREFIX@/lib/libhdhomerun.dylib' </div>
<div> Referenced from:
'/private/var/folders/4c/__l40lp140324rnbz1m2jkgh0000gn/T/ffconf.xBPEc1aO/test'</div>
Reason: tried: '/usr/local/lib/libhdhomerun.dylib' (no
such file), '/usr/lib/libhdhomerun.dylib' (no such file)<br>
```<br>
<br>
That looks suspicious to me. Would that prevent the test
from executing?<br>
<br>
</div>
</blockquote>
<div><br>
</div>
<div>That was the culprit. It appears that configure pretty
much stopped running at this point. Uninstalling hdhome
seems to have allowed configure to complete successfully. </div>
<div><br>
</div>
<div>Also, a fix for hdhomerun was pushed to macports last
night (Thank you Craig!!!!). It appears that everything now
gets through configure cleanly. Sorry to send you down the
weeds of a package management issue.</div>
</div>
</div>
</blockquote>
<br>
Our GitHub Actions use Homebrew, so if the root cause is a package
management issue, that would be why MythTV's Actions work.<br>
<br>
<blockquote type="cite"
cite="mid:CAE8sghThC+1MJ5xuDQ=FUwWDMPFqM2O3a8Uw_rv-qCaTM73ZDw@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div> The resultant config.h files from our configure and
FFmpeg's would be useful to compare.<br>
</div>
</blockquote>
<div><br>
</div>
<div>mythtv's config.h is here: <a
href="https://pastebin.com/xavF0smp"
moz-do-not-send="true" class="moz-txt-link-freetext">https://pastebin.com/xavF0smp</a></div>
</div>
</div>
</blockquote>
<br>
```<br>
<div class="de1">#define HAVE_LRINT 0
</div>
...<br>
#define HAVE_ROUND 0<br>
```<br>
<br>
If this was from before uninstalling libhdhomerun, it is as I
expected, and all of the other math functions are defined 1. <br>
<br>
<blockquote type="cite"
cite="mid:CAE8sghThC+1MJ5xuDQ=FUwWDMPFqM2O3a8Uw_rv-qCaTM73ZDw@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<div>ffmpeg'sconfig.h is here:<a
href="https://pastebin.com/XprwzBbw"
moz-do-not-send="true"> https://pastebin.com/XprwzBbw</a></div>
</div>
</div>
</blockquote>
<br>
"This paste has been deemed potentially harmful."<br>
<br>
I assume FFmpeg's config.h defines HAVE_LRINT and HAVE_ROUND to 1,
based on the compile errors.<br>
<br>
<blockquote type="cite"
cite="mid:CAE8sghThC+1MJ5xuDQ=FUwWDMPFqM2O3a8Uw_rv-qCaTM73ZDw@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div> I would prefer to fix configure, rather than hack
around the error.<br>
<br>
Were the HAVE_LRINTF changes necessary? I don't think
they should be.<br>
<br>
I think a better solution is to remove the referenced
configure lines and see if that works. My reasoning is
the following:<br>
<br>
<ol>
<li>`git grep -nE "math.h" -- :^*/FFmpeg/**
:^platform/**` We use <cmath> not
<math.h>, except in external/libexiv2.</li>
<li>We never use lrint() `git grep -nE lrint --
:^*/FFmpeg/**` only lrintf().</li>
<ul>
<li>Although, we do use round(), `git grep -nE
"[^A-Za-z]round\(" -- :^*/FFmpeg/** :^*/html/**`.<br>
</li>
</ul>
<li>We are using C++17, these functions are from
C99/C++11.<br>
</li>
</ol>
</div>
</blockquote>
<div>Happy to try this but also believe this is probably
overcome by the hdhomerun fix.</div>
<div><br>
</div>
</div>
</div>
</blockquote>
<br>
If the updated libhdhomerun package fixes this, you don't need to
test the configure change.<br>
<br>
<blockquote type="cite"
cite="mid:CAE8sghThC+1MJ5xuDQ=FUwWDMPFqM2O3a8Uw_rv-qCaTM73ZDw@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<div>Thanks again for the help!</div>
</div>
</div>
</blockquote>
<br>
No problem.<br>
<br>
Regards,<br>
<br>
Scott<br>
<br>
</body>
</html>