<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
On 11/23/22 18:37, John Hoyt wrote:<br>
<blockquote type="cite"
cite="mid:CAE8sghSxs90Ok5YMu0vyE9C6KxKAsmRHB1WiZ5G4W=RFgPto7A@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr"><br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Nov 23, 2022 at 6:28
PM John Hoyt <<a href="mailto:john.hoyt@gmail.com"
moz-do-not-send="true" class="moz-txt-link-freetext">john.hoyt@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div class="gmail_quote">
<div>Hi Scott, thanks for taking a look. I've worked up
a patch file to resolve, but it sounds like getting
configure working correctly is a better solution
(happy to post the patch file).</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px
0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>Without the outputs from configure, particularly
the log file config.ep, I can't say for certain if
those lines are the problem.<br>
</div>
</blockquote>
<div><br>
</div>
<div>Configure output: <a
href="https://pastebin.com/gG8E1Fbg" target="_blank"
moz-do-not-send="true" class="moz-txt-link-freetext">https://pastebin.com/gG8E1Fbg</a></div>
<div>config.ep: <a href="https://pastebin.com/b6Tk5M4Q"
target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">https://pastebin.com/b6Tk5M4Q</a></div>
</div>
</div>
</blockquote>
<div><br>
</div>
</div>
</div>
</blockquote>
<br>
from config.ep line 5736:<br>
```<br>
<div class="de1">dyld[67989]: Library not loaded:
'@PREFIX@/lib/libhdhomerun.dylib'
</div>
<div class="de1"> Referenced from:
'/private/var/folders/4c/__l40lp140324rnbz1m2jkgh0000gn/T/ffconf.xBPEc1aO/test'</div>
Reason: tried: '/usr/local/lib/libhdhomerun.dylib' (no such file),
'/usr/lib/libhdhomerun.dylib' (no such file)<br>
```<br>
<br>
That looks suspicious to me. Would that prevent the test from
executing?<br>
<br>
The resultant config.h files from our configure and FFmpeg's would
be useful to compare.<br>
<br>
<blockquote type="cite"
cite="mid:CAE8sghSxs90Ok5YMu0vyE9C6KxKAsmRHB1WiZ5G4W=RFgPto7A@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<div>BTW - I can now reproduce on a local machine (wife's
macbook) running Monterey. Strangely, all of my Ventura
machines do not exhibit the problem. </div>
<div><br>
</div>
<div>Here's the patch I worked up that successfully compiles:</div>
</div>
<blockquote style="margin:0 0 0 40px;border:none;padding:0px">
<div class="gmail_quote">
<div>diff --git a/mythtv/external/FFmpeg/libavutil/libm.h
b/mythtv/external/FFmpeg/libavutil/libm.h</div>
</div>
<div class="gmail_quote">
<div>index a819962391..71753deff5 100644</div>
</div>
<div class="gmail_quote">
<div>--- a/mythtv/external/FFmpeg/libavutil/libm.h</div>
</div>
<div class="gmail_quote">
<div>+++ b/mythtv/external/FFmpeg/libavutil/libm.h</div>
</div>
<div class="gmail_quote">
<div>@@ -427,21 +427,21 @@ static inline double rint(double
x)</div>
</div>
<div class="gmail_quote">
<div> #endif /* HAVE_RINT */</div>
</div>
<div class="gmail_quote">
<div> </div>
</div>
<div class="gmail_quote">
<div> #if !HAVE_LRINT</div>
</div>
<div class="gmail_quote">
<div>-static av_always_inline av_const long int lrint(double
x)</div>
</div>
<div class="gmail_quote">
<div>+av_always_inline av_const long int lrint(double x)</div>
</div>
<div class="gmail_quote">
<div> {</div>
</div>
<div class="gmail_quote">
<div> return rint(x);</div>
</div>
<div class="gmail_quote">
<div> }</div>
</div>
<div class="gmail_quote">
<div> #endif /* HAVE_LRINT */</div>
</div>
<div class="gmail_quote">
<div> </div>
</div>
<div class="gmail_quote">
<div> #if !HAVE_LRINTF</div>
</div>
<div class="gmail_quote">
<div>-static av_always_inline av_const long int lrintf(float
x)</div>
</div>
<div class="gmail_quote">
<div>+av_always_inline av_const long int lrintf(float x)</div>
</div>
<div class="gmail_quote">
<div> {</div>
</div>
<div class="gmail_quote">
<div> return (int)(rint(x));</div>
</div>
<div class="gmail_quote">
<div> }</div>
</div>
<div class="gmail_quote">
<div> #endif /* HAVE_LRINTF */</div>
</div>
<div class="gmail_quote">
<div> </div>
</div>
<div class="gmail_quote">
<div> #if !HAVE_ROUND</div>
</div>
<div class="gmail_quote">
<div>-static av_always_inline av_const double round(double
x)</div>
</div>
<div class="gmail_quote">
<div>+av_always_inline av_const double round(double x)</div>
</div>
<div class="gmail_quote">
<div> {</div>
</div>
<div class="gmail_quote">
<div> return (x > 0) ? floor(x + 0.5) : ceil(x -
0.5);</div>
</div>
<div class="gmail_quote">
<div> }</div>
</div>
<div class="gmail_quote">
<div>diff --git a/mythtv/libs/libmyth/audio/audioconvert.cpp
b/mythtv/libs/libmyth/audio/audioconvert.cpp</div>
</div>
<div class="gmail_quote">
<div>index 98a2e25c8c..1b7903e599 100644</div>
</div>
<div class="gmail_quote">
<div>--- a/mythtv/libs/libmyth/audio/audioconvert.cpp</div>
</div>
<div class="gmail_quote">
<div>+++ b/mythtv/libs/libmyth/audio/audioconvert.cpp</div>
</div>
<div class="gmail_quote">
<div>@@ -71,7 +71,7 @@ static inline bool sse_check()</div>
</div>
<div class="gmail_quote">
<div> #endif //ARCH_x86</div>
</div>
<div class="gmail_quote">
<div> </div>
</div>
<div class="gmail_quote">
<div> #if !HAVE_LRINTF</div>
</div>
<div class="gmail_quote">
<div>-static av_always_inline av_const long int lrintf(float
x)</div>
</div>
<div class="gmail_quote">
<div>+av_always_inline av_const long int lrintf(float x)</div>
</div>
<div class="gmail_quote">
<div> {</div>
</div>
<div class="gmail_quote">
<div> return (int)(rint(x));</div>
</div>
<div class="gmail_quote">
<div> }</div>
</div>
</blockquote>
</div>
<br>
</blockquote>
<br>
I would prefer to fix configure, rather than hack around the error.<br>
<br>
Were the HAVE_LRINTF changes necessary? I don't think they should
be.<br>
<br>
I think a better solution is to remove the referenced configure
lines and see if that works. My reasoning is the following:<br>
<br>
<ol>
<li>`git grep -nE "math.h" -- :^*/FFmpeg/** :^platform/**` We use
<cmath> not <math.h>, except in external/libexiv2.</li>
<li>We never use lrint() `git grep -nE lrint -- :^*/FFmpeg/**`
only lrintf().</li>
<ul>
<li>Although, we do use round(), `git grep -nE
"[^A-Za-z]round\(" -- :^*/FFmpeg/** :^*/html/**`.<br>
</li>
</ul>
<li>We are using C++17, these functions are from C99/C++11.<br>
</li>
</ol>
Regards,<br>
<br>
Scott<br>
<br>
</body>
</html>