<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
On 10/1/22 06:35, Paul Harrison wrote:<br>
<blockquote type="cite"
cite="mid:758abfe0-5b68-214b-e295-93151b862d3c@mythqml.net">On
01/10/2022 02:23, Scott Theisen wrote:
<br>
<blockquote type="cite">On 9/30/22 20:35, Paul Harrison wrote:
<br>
<blockquote type="cite">I meant to say it doesn't seem a good
enough reason to break all themes IMHO? If it was for a
feature addition or change then I can live with it but for
what appears to be some code clean up I'm not so sure.
<br>
<br>
<br>
Paul H.
<br>
<br>
</blockquote>
<br>
I don't understand this comment; it doesn't seem to follow the
rest. Setting the subtitle of a manual recording in
mythfrontend is a new feature.
<br>
<br>
Regards,
<br>
<br>
Scott
<br>
<br>
</blockquote>
<br>
Ah!. Sorry I didn't look at the pull request I assumed this was
for the theme changes required because of this comment although I
admit I didn't look too closely at what needs to change and
whether it's a good enough reason to break stuff.
<br>
<br>
<a class="moz-txt-link-freetext" href="https://github.com/MythTV/mythtv/pull/642#issuecomment-1260210103">https://github.com/MythTV/mythtv/pull/642#issuecomment-1260210103</a>
<br>
<br>
<br>
My concern is we known from the likes of the SD statistics that we
are loosing users at a alarming rate so the last thing we need is
for stuff to be broken like themes that can be avoided otherwise a
lot of users will just say sod it it's broken again I don't need
this anymore and it's another user lost. We need to make life
easier for users not harder.
<br>
<br>
<br>
Paul H.
<br>
<br>
</blockquote>
<br>
The bundled themes don't use <<span class="pl-ent">window</span>
<span class="pl-e">name</span>=<span class="pl-s"><span
class="pl-pds">"</span>program_info<span class="pl-pds">"</span></span>>
<<span class="pl-ent">statetype</span> <span class="pl-e">name</span>=<span
class="pl-s"><span class="pl-pds">"</span>audiocodec<span
class="pl-pds">"</span></span>>, which is what the linked
comment is about. Adding the few extra <state>s is perfectly
backwards compatible.<br>
<br>
I understand the desire to not break things, which is why the new
<window name="manualschedule"> <textedit
name="subtitle"> is optional. The theme change is backwards
compatible, but has the downside that the new textedit widget does
not effect anything without the MythTV change.<br>
<br>
Regards,<br>
<br>
Scott<br>
<br>
</body>
</html>