<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 9/28/20 1:28 PM, Michael T. Dean
wrote:<br>
</div>
<blockquote type="cite" cite="mid:5F721D36.9070407@thirdcontact.com"><br>
<blockquote type="cite" style="color: #000000;">I am not sure if
SQL will correctly group items that have null in their group by
column.
<br>
<br>
Should null channel numbers be allowed?
<br>
</blockquote>
<br>
The column is defined as NOT NULL:
<br>
<br>
<a class="moz-txt-link-freetext"
href="https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmythtv/dbcheck.cpp#L3894"
moz-do-not-send="true">https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmythtv/dbcheck.cpp#L3894</a>
<br>
<br>
and I don't see any changes anywhere that removed that restriction
(nor can I imagine changes that would do that). Not sure what the
preferred approach is regarding coding to handle that invalid data
transparently or requiring valid data, but we probably should at
least alert the user that their DB (and, seemingly DB schema) is
borked if we notice that--whether we fail hard or "just try and
see" or insert some value in code when reading null from the DB
column to try to prevent errors. My personal preference is to not
spend a lot of time coding to handle invalid data, but to log a
message that makes it possible for the user to figure out what's
wrong and correct it. That said, I'm not at all against
bulletproof (or bullet-resistant?) code. (So, I guess that's
completely useless advice, and maybe someone else can be more
helpful. <span class="moz-smiley-s1" title=":)"><span>:)</span></span></blockquote>
<p>I don't know how the null values occurred. I did not see the
user's database. I am using the services api so maybe it was an
empty string. The xml parser will treat that as null.</p>
<p>I will get a fix for the Guide API to group by callsign and
channel number as you suggested.</p>
<p>Peter<br>
</p>
</body>
</html>