<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 19, 2018 at 10:04 AM Peter Bennett <<a href="mailto:pb.mythtv@gmail.com">pb.mythtv@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div text="#000000" bgcolor="#FFFFFF">
    <p>Hi Aman</p>
    <p>I resubmitted the patch.<br>
    </p>
    <p>I hope I did a better job this time. I did a compare and the
      mediacodec_sw_buffer.c file in my MythTV repository is now
      identical to the one in my FFmpeg repository after the patch.<br></p></div></blockquote><div><br></div><div>FYI I've committed a different fix for this bug to ffmpeg master and release/4.0 branches.</div><div><br></div><div>Aman</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><p>
    </p>
    Peter<br>
    <br>
    <div class="m_-6522443132402912969moz-cite-prefix">On 07/19/2018 12:42 PM, Aman Gupta
      wrote:<br>
    </div>
    <blockquote type="cite">
      
      Yes please submit the fixed patch to the list.<br>
      <br>
      Aman<br>
      <div class="gmail_quote">
        <div dir="ltr">On Thu, Jul 19, 2018 at 9:41 AM Peter Bennett
          <<a href="mailto:pb.mythtv@gmail.com" target="_blank">pb.mythtv@gmail.com</a>> wrote:<br>
        </div>
        <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
          <div text="#000000" bgcolor="#FFFFFF">
            <p>Hi Aman<br>
            </p>
            <p>The original patch is correct. Sorry. I need a better
              process for this. The patch from MythTV does not apply in
              FFmpeg because of the different path, so I changed it
              manually, wrongly. I will fix that. Can I resubmit the
              patch once fixed?</p>
          </div>
          <div text="#000000" bgcolor="#FFFFFF">
            <p>Peter<br>
            </p>
          </div>
          <div text="#000000" bgcolor="#FFFFFF"> <br>
            <div class="m_-6522443132402912969m_-8247385900571795361moz-cite-prefix">On
              07/19/2018 12:11 PM, Aman Gupta wrote:<br>
            </div>
            <blockquote type="cite">
              <div dir="ltr">Hi Peter,
                <div><br>
                </div>
                <div>The patch you submitted to the list changes <span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">ff_mediacodec_sw_buffer_copy_y</span><span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">uv420_planar,
                    but the patch you sent me above
                    changes ff_mediacodec_sw_buffer_copy_yuv420_semi_planar</span></div>
                <div><span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br>
                  </span></div>
                <div><span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Which
                    one is correct?</span></div>
                <div><span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br>
                  </span></div>
                <div><span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Aman</span></div>
              </div>
              <br>
              <div class="gmail_quote">
                <div dir="ltr">On Wed, Jul 18, 2018 at 12:06 PM Aman
                  Gupta <<a href="mailto:aman@tmm1.net" target="_blank">aman@tmm1.net</a>>
                  wrote:<br>
                </div>
                <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                  <div dir="ltr">Please submit to ffmpeg-devel so others
                    can review. I will commit if there are no objections
                    there.
                    <div><br>
                    </div>
                    <div>Aman</div>
                  </div>
                  <br>
                  <div class="gmail_quote">
                    <div dir="ltr">On Wed, Jul 18, 2018 at 12:03 PM
                      Peter Bennett <<a href="mailto:pb.mythtv@gmail.com" target="_blank">pb.mythtv@gmail.com</a>>
                      wrote:<br>
                    </div>
                    <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi
                      Aman<br>
                      <br>
                      This patch fixes the seg fault in mediacodec with
                      1080i playback on <br>
                      android oreo. Also I have confirmation from others
                      who have tried it <br>
                      that it does not cause any issue with earlier
                      android versions. Please <br>
                      can you get it committed to FFmpeg. See attached
                      file.<br>
                      <br>
                      Peter<br>
                      <br>
                    </blockquote>
                  </div>
                </blockquote>
              </div>
            </blockquote>
            <br>
          </div>
        </blockquote>
      </div>
    </blockquote>
    <br>
  </div>

</blockquote></div></div>