<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 05/19/2018 02:53 PM, Peter Bennett
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:62242518-94e3-d442-f34e-e2737393dfcc@gmail.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 05/19/2018 10:25 AM, Gary
Buhrmaster wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAMfXtQwMcWLv38Oq2jPecAJwnvO-qTUipJ-_QPVBWak5tRN4bA@mail.gmail.com">
<pre wrap="">Just so you understand, the github download (at a commit)
does <b class="moz-txt-star"><span class="moz-txt-tag">*</span>NOT<span class="moz-txt-tag">*</span></b> generate a git repo (this is not a git clone).</pre>
</blockquote>
I know that.<br>
<blockquote type="cite"
cite="mid:CAMfXtQwMcWLv38Oq2jPecAJwnvO-qTUipJ-_QPVBWak5tRN4bA@mail.gmail.com">
<pre wrap="">You cannot issue git commands from inside the directory
that is (eventually) created from that download when
running configure.
</pre>
</blockquote>
Configure and make already issue git commands. That is how they
currently generate the version number, which is from a "git
describe --dirty" command. They have appropriate checks in place
to cater for users that are building from a downloaded tar file.
In that case the version number is created a different way. <br>
<br>
In the same way, I would put in place appropriate checks to ensure
that git is not called when there is no git repository.<br>
<br>
I will perform a test to see what is downloaded from git when you
request a zip or tar file. If that download does not contain the
full source of the correct commit of the submodule, then this
approach is a non-starter.<br>
<blockquote type="cite"
cite="mid:CAMfXtQwMcWLv38Oq2jPecAJwnvO-qTUipJ-_QPVBWak5tRN4bA@mail.gmail.com">
<pre wrap="">If the project wishes to no longer support the ability to
download from github in that way to build, and/or to
presume build hosts will have internet connectivity
(to perform other git operations), that is up to the
project, but it will be a change in the existing practice.
</pre>
</blockquote>
If is does not work as it always has, then I will be doing it
another way.<br>
<br>
</blockquote>
Looking at some issues reported on github e.g.
<a class="moz-txt-link-freetext" href="https://github.com/dear-github/dear-github/issues/214">https://github.com/dear-github/dear-github/issues/214</a>), it seems
that the tar or zip file download does not include the submodule. I
believe that effectively kills the idea of using a submodule for
FFmpeg or any external component.<br>
<br>
Peter<br>
<br>
</body>
</html>