<div dir="ltr">On Sat, Sep 16, 2017 at 6:16 PM David Engel <<a href="mailto:david@istwok.net">david@istwok.net</a>> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Sat, Sep 16, 2017 at 11:30:04PM +0000, John P Poet wrote:<br>
> On Sat, Sep 16, 2017 at 3:03 PM John P Poet <<a href="mailto:jppoet@gmail.com" target="_blank">jppoet@gmail.com</a>> wrote:<br>
><br>
> > On Thu, Sep 14, 2017 at 7:11 PM, Git Repo Owner <<a href="mailto:noreply@mythtv.org" target="_blank">noreply@mythtv.org</a>><br>
> > wrote:<br>
> ><br>
> >> The branch, master has been updated on the<br>
> >> mythtv repository by gitolite user gigem.<br>
> >> via d2d92b2d34c08db5092c0ee0e5b432efa7c58f97 (commit)<br>
> >> via e82386cbced67f5f0e36d36be833b162f9847299 (commit)<br>
> >> from 39c9292fdc9385dbee25faf5bca8ca6b1d67b31b (commit)<br>
> >><br>
> >> Those revisions listed above that are new to this repository have<br>
> >> not appeared on any other notification email; so we list those<br>
> >> revisions in full, below.<br>
> >><br>
> >> - Log -----------------------------------------------------------------<br>
> >> commit d2d92b2d34c08db5092c0ee0e5b432efa7c58f97<br>
> >> Author: David Engel <<a href="mailto:dengel@mythtv.org" target="_blank">dengel@mythtv.org</a>> at Thu, 14 Sep 2017 20:03:21<br>
> >> -0500<br>
> >> Committer: David Engel <<a href="mailto:dengel@mythtv.org" target="_blank">dengel@mythtv.org</a>> at Thu, 14 Sep 2017 20:03:21<br>
> >> -0500<br>
> >> URL:<br>
> >> <a href="http://code.mythtv.org/cgit/mythtv/commit/?id=d2d92b2d34c08db5092c0ee0e5b432efa7c58f97" rel="noreferrer" target="_blank">http://code.mythtv.org/cgit/mythtv/commit/?id=d2d92b2d34c08db5092c0ee0e5b432efa7c58f97</a><br>
> >><br>
> >> Remove QueryInputDisplayName/kUnknownInputName nonsense.<br>
> >> As I remember it, when inputname was added to ProgramInfo, we didn't<br>
> >> want to further bloat the Myth protocol by passing it around too.<br>
> >> Instead, we made provisions to load it on demand from the database.<br>
> >> Later, someone else realized lots of database queries were happening<br>
> >> to get the inputname and slowing things down, so they added inputname<br>
> >> to the protocol. This change [hopefully] makes sure inputname<br>
> >> initially gets set everywhere it should and removes all vestiges of<br>
> >> the load on demand support.<br>
> >><br>
> >><br>
> >><br>
> >> commit e82386cbced67f5f0e36d36be833b162f9847299<br>
> >> Author: David Engel <<a href="mailto:dengel@mythtv.org" target="_blank">dengel@mythtv.org</a>> at Thu, 14 Sep 2017 13:39:24<br>
> >> -0500<br>
> >> Committer: David Engel <<a href="mailto:dengel@mythtv.org" target="_blank">dengel@mythtv.org</a>> at Thu, 14 Sep 2017 20:02:07<br>
> >> -0500<br>
> >> URL:<br>
> >> <a href="http://code.mythtv.org/cgit/mythtv/commit/?id=e82386cbced67f5f0e36d36be833b162f9847299" rel="noreferrer" target="_blank">http://code.mythtv.org/cgit/mythtv/commit/?id=e82386cbced67f5f0e36d36be833b162f9847299</a><br>
> >><br>
> >> Enhance RecStatus::toString() to allow a replacement string.<br>
> >> A future change will allow use of a shortened inputname instead of<br>
> >> just the numberic inputid.<br>
> >><br>
> >><br>
> >><br>
> >> -----------------------------------------------------------------------<br>
> >><br>
> >> Summary of changes:<br>
> >> mythtv/libs/libmyth/programinfo.cpp | 75<br>
> >> +++-----------------<br>
> >> mythtv/libs/libmyth/programinfo.h | 3 +-<br>
> >> mythtv/libs/libmythbase/mythversion.h | 2 +-<br>
> >> .../libmythservicecontracts/enums/recStatus.cpp | 16 +++--<br>
> >> .../libs/libmythservicecontracts/enums/recStatus.h | 1 +<br>
> >> mythtv/libs/libmythtv/recordinginfo.cpp | 9 ++-<br>
> >> mythtv/libs/libmythtv/recordinginfo.h | 3 +-<br>
> >> mythtv/programs/mythbackend/scheduler.cpp | 13 +++-<br>
> >> mythtv/programs/mythfrontend/progdetails.cpp | 2 +-<br>
> >> 9 files changed, 41 insertions(+), 83 deletions(-)<br>
> >><br>
> >> --<br>
> ><br>
> ><br>
> > Hi David,<br>
> ><br>
> > Commit d2d92b2d34c08db5092c0ee0e5b432efa7c58f97 breaks the Steppes<br>
> > theme. In the "Upcoming Recordings" screen, it is supposed to show the<br>
> > name of the input that will be used. Starting with this commit, it just<br>
> > shows a tilde (~) instead.<br>
> ><br>
><br>
> Actually, it breaks all themes. In "Upcoming Recordings", hit (I)nfo twice<br>
> and the "Recording Input" is now showing as a tilde.<br>
<br>
It certainly didn't do that for me when I tested it. I will test it<br>
again, but can't do so right now. My dev system shares some normally<br>
unused, networked tuners with my production system, but they are busy<br>
right now.<br>
<br>
In the meantime, can you try a distclean and rebuild? That tilde<br>
business is exactly what I removed. Maybe something didn't get<br>
rebuilt when in should have.<br>
<br>
David<br><br></blockquote><div><br></div><div>Hi David,<br><br>distclean did not help.<br><br>When you say "That tilde business is exactly what I removed.", are you saying that you saw the ~ before that commit? Because, if I "git checkout e82386cbced67", and build that, it works as expected.<br><br></div><div>John<br><br></div></div></div>