<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>
</p>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode">Hi Stuart
<br>
Re-sending this email because I had sent it from the wrong
address.<br>
<br>
Regarding ticket #13020
<br>
<a class="moz-txt-link-freetext"
href="https://code.mythtv.org/trac/ticket/13020">https://code.mythtv.org/trac/ticket/13020</a>
<br>
<br>
I want to make sure what I am doing will be consistent with the
release process.
<br>
<br>
Currently, only if MythTV is built with from a git branch called
fixes/something is the theme download done from the specific
version. In all other cases the themes are taken from trunk. All
builds from a git export zip get their themes from trunk. (<a
class="moz-txt-link-freetext"
href="http://themes.mythtv.org/themes/repository/trunk/themes.zip">http://themes.mythtv.org/themes/repository/trunk/themes.zip</a>)
<br>
<br>
I am making changes in the build to ensure the correct version is
obtained from git, or the tag name in EXPORTED_VERSION, or the
VERSION file.
<br>
<br>
I am changing theme download to use "trunk" only if
<br>
- the version includes "-pre" (case insensitive),
<br>
or
<br>
- the version does not start with a v and a number. I am changing
the compile to fail if the version does not start with v and a
number, so this should never happen.
<br>
<br>
We need to make sure:
<br>
- The mythtv/VERSION file has the correct version e.g. "v29-pre"
or "v29" or "v29.1". For Release candidates, use "v29-rc1",
"v29-rc2", etc.
<br>
- There must be a git tag with the same value as the version on
the same branch.
<br>
- There must be a themes.zip file <a
class="moz-txt-link-freetext"
href="http://themes.mythtv.org/themes/repository/29/themes.zip">http://themes.mythtv.org/themes/repository/29/themes.zip</a>
available as soon as we create a "v29-rc1" or "v29" version and
tag.
<br>
- The MYTH_BINARY_VERSION in libmythbase/mythversion.h must have
the same major version. In the version is v29, v29-pre, v29.1 the
MYTH_BINARY_VERSION must be 29.xxxxxxxxxx. I am adding a check to
fail the compile if this is not the case.
<br>
<br>
Note that the theme download caters for themes with subversions,
as follows:
<br>
<br>
These exist
<br>
<a class="moz-txt-link-freetext"
href="http://themes.mythtv.org/themes/repository/0.27/themes.zip">http://themes.mythtv.org/themes/repository/0.27/themes.zip</a>
<br>
<a class="moz-txt-link-freetext"
href="http://themes.mythtv.org/themes/repository/0.27.1/themes.zip">http://themes.mythtv.org/themes/repository/0.27.1/themes.zip</a>
<br>
<a class="moz-txt-link-freetext"
href="http://themes.mythtv.org/themes/repository/0.28/themes.zip">http://themes.mythtv.org/themes/repository/0.28/themes.zip</a>
<br>
<br>
But this does not
<br>
<a class="moz-txt-link-freetext"
href="http://themes.mythtv.org/themes/repository/0.28.1/themes.zip">http://themes.mythtv.org/themes/repository/0.28.1/themes.zip</a>
<br>
<br>
Have we abandoned or forgotten to create theme downloads for
subversions of 0.28? Or maybe that is only for special
circumstances.
<br>
<br>
In the code it looks for all earlier subversions then ultimately
for the main version. For example if you are on 0.28.2 it looks
for 0.28.2, then 0.28.1, then 0.28. It downloads all that are
found.
<br>
<br>
In the 29 version, it will only cater for 1 level of subversions,
i.e. it will look for 29.2 , 29.1, 29, but not 29.2.1. 29.2.1
would be treated the same as 29.2.
<br>
<br>
It seems to me that catering for subversions in themes is
overkill. There does not seem to be anything in theme files that
is not backwards compatible. Due to the above mentioned bug, many
users today are downloading trunk versions of themes onto their
0.28 or 0.27 systems will no reported problem.
<br>
<br>
Any comments before I commit the changes?
<br>
<br>
Peter
<br>
</div>
</body>
</html>