[mythtv] Comments requested on two bugs

[Peter Bennett]

On 3/26/23 13:18, David Engel wrote:
> On Sun, Mar 26, 2023 at 11:19:20AM -0400, Peter Bennett wrote:
>> There are two bugs I have logged, with my recommended fixes.
>>
>> https://github.com/MythTV/mythtv/issues/739
>>
>> I am proposing removing the use of std::move. The different ways of
>> accessing QString, and how the memory is managed com into this. I ran some
>> tests of the solution, and I could not find any memory leaks. If there is
>> anything wrong with this approach please let me know.
> I don't know enough about this issue to comment.
>
>> https://github.com/MythTV/mythtv/issues/740
>>
>> In one field the API is returning different values in xml and json. The fix
>> may affect users of the xml API. I believe we need to fix it anyway.
> Returning the same value in both modes is desirable.  However, is this
> API element new in pre-v34?  Or IOW, do we know how many existing, API
> users that would break?

This element has been there since 0.28 and I believe it has been 
behaving this way since then.

I don't know how many users there are of the api.

If I change the api to return names in all cases and change the method 
that translates the code to a description so that it accepts names as 
well as codes, that should be the least impact.


> David