[mythtv] [mythtv-commits] [MythTV/mythtv] d54bb6: Terminate Live TV channel input with SELECT

[David Engel]

On Sat, Jun 03, 2023 at 11:20:13AM -0500, David Engel wrote:
> On Sat, Jun 03, 2023 at 10:34:32AM +0200, Klaas de Waal wrote:
> > On Fri, 2 Jun 2023 at 22:48, David Engel <david at istwok.net> wrote:
> > > Also, why is this commit necessary at all?  Pressing
> > > SELECT has started a channel change for several years already.
> > >
> > > On my system the Enter key does not terminate live TV channel number input
> > and I have to wait for the timeout.
> > Lack of a way to terminate live TV channel number input has also been
> > reported on the mailing list a few months ago.
> > Could it be that there is a configuration setting that controls this
> > behavior?
> 
> I'll check my own code.  Maybe a local change has kept it working for
> me.  I know it worked many, many years ago.  In fact, I suggested back
> then to require the SELECT and Isaac vetoed it.

It wasn't my code.  It was my key bindings, sort of.

I believe the regression dates back to commit 5f9ddd6d.  Before that
commit, pressing SELECT would call CommitQueuedInput() if applicable,
otherwise, it would set the bookmark.  After that commit,
CommitQueuedInput() could only get called if the key was one of the
bookmark actions.  I believe the correct fix is to move the
CommitQueuedInput() logic ahead of the BOOKMARK checks and explicitly
check for SELECT instead of any custom binding.

I didn't see this bug because I still have the legacy, key binding
which ties SELECT to SETBOOKMARK.

David
-- 
David Engel
david at istwok.net