[mythtv] [mythtv-commits] [MythTV/mythtv] d54bb6: Terminate Live TV channel input with SELECT

[Klaas de Waal]

On Fri, 2 Jun 2023 at 22:48, David Engel <david at istwok.net> wrote:

> On Fri, May 19, 2023 at 02:35:34PM -0700, kmdewaal via mythtv-commits
> wrote:
> >   Branch: refs/heads/master
> >   Home:   https://github.com/MythTV/mythtv
> >   Commit: d54bb609dac731cee6315ad3d810c1d1edc6ced4
> >
> https://github.com/MythTV/mythtv/commit/d54bb609dac731cee6315ad3d810c1d1edc6ced4
> >   Author: Klaas de Waal <klaas at kldo.nl>
> >   Date:   2023-05-19 (Fri, 19 May 2023)
> >
> >   Changed paths:
> >     M mythtv/libs/libmythtv/tv_play.cpp
> >
> >   Log Message:
> >   -----------
> >   Terminate Live TV channel input with SELECT
> >
> > In Live TV another channel can be selected by typing in the channel
> number.
> > The selection takes effect five seconds after the first character has
> been entered.
> > The channel number input can now be terminated by a SELECT action (the
> Enter key).
>
> Klaas, this commit breaks the exiting of fast-forward and rewind by
> pressing SELECT.


David, thanks for testing. Regressions should not happen of course.
Reverted this in commit 1594f64c7e705b7c87ac2b1ed9a954d7d2b144ef.


> Also, why is this commit necessary at all?  Pressing
> SELECT has started a channel change for several years already.
>
> On my system the Enter key does not terminate live TV channel number input
and I have to wait for the timeout.
Lack of a way to terminate live TV channel number input has also been
reported on the mailing list a few months ago.
Could it be that there is a configuration setting that controls this
behavior?

Thanks,
Klaas.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-dev/attachments/20230603/ca7114cf/attachment.htm>