[mythtv] Errant Version.pm being added to perl install directory

[David Hampton]

On Mon, 2023-01-23 at 18:23 +0000, John Pilkington wrote:
> On 23/01/2023 18:05, David Hampton via mythtv-dev wrote:
> > On Mon, 2023-01-23 at 16:51 +0000, John Pilkington wrote:
> > > On 23/01/2023 16:15, Gary Buhrmaster wrote:
> > > > On Mon, Jan 23, 2023 at 3:35 PM David Hampton via mythtv-dev
> > > > <mythtv-dev at mythtv.org> wrote:
> > > > 
> > > > > True, but this method makes it easier to port the change to
> > > > > cmake.
> > > > 
> > > > The goal of cmake is good.
> > > > 
> > > > > Cmake has a configure_file function specifically designed to
> > > > > do
> > > > > this
> > > > > kind of substitution.
> > > > 
> > > > So why not use it to configure the Makefile.PL "Version"
> > > > string directly?  As my patch demonstrated, one does not
> > > > have to pull the version from a file, it can be directly
> > > > specified.
> > > 
> > > FWIW (??), and fyi, the error I reported on the users list was
> > > 
> > > Checking for unpackaged file(s): /usr/lib/rpm/check-files
> > > /builddir/build/BUILDROOT/mythtv-33.Pre.1075.gb6428abd82-
> > > 100.fc36.x86_64
> > > error: Installed (but unpackaged) file(s) found:
> > >      /usr/share/perl5/vendor_perl/Version.pm
> > > 
> > > followed by a short list of files listed twice.
> > > 
> > > -------
> > > Today, after replacing all instances of MythTV.pm in mythtv.spec
> > > by
> > > 
> > >    /MythTV/Version.pm
> > > 
> > > I get
> > > 
> > > Checking for unpackaged file(s): /usr/lib/rpm/check-files
> > > /builddir/build/BUILDROOT/mythtv-33.Pre.1109.g6f04854c27-
> > > 100.fc36.x86_64
> > > error: Installed (but unpackaged) file(s) found:
> > >      /usr/share/perl5/vendor_perl/IO/Socket/INET/MythTV.pm
> > >      /usr/share/perl5/vendor_perl/MythTV.pm
> > 
> > That's odd.  I just compared my fixes-32 and master install
> > directories, and these are the only things I see changed:
> > 
> >    Files fixes-32/share/perl5/5.36/MythTV/Program.pm and
> >      master/share/perl5/5.36/MythTV/Program.pm differ
> >    Only in master/share/perl5/5.36/MythTV: Version.pm
> >    Files fixes-32/share/perl5/5.36/MythTV.pm and
> >      master/share/perl5/5.36/MythTV.pm differ
> >    Files fixes-32/lib64/perl5/5.36/auto/MythTV/.packlist and
> >      master/lib64/perl5/5.36/auto/MythTV/.packlist differ
> > 
> > This is on my Fedora 37 development system.  How are you building
> > packages?  Are you using Gary's scripts?
> 
> Yes.  IIRC the only changes now are those I mentioned in the specfile
> and using a locally updated clone instead of cloning directly from
> the remote for every build.
> 

OK. I just updated my copy of Gary's build scripts and am starting a
build.  I'll see what I get here.

David