[mythtv] Consideration of removing dblogging

Bill Meek keemllib at gmail.com
Sat Apr 1 16:05:02 UTC 2023


On Saturday 01 April 2023 09:36:58 AM (-05:00), David Hampton via mythtv-dev wrote:

> On Wed, 2023-03-22 at 10:42 -0500, David Engel wrote:
> > On Wed, Mar 22, 2023 at 01:00:12AM +0000, Gary Buhrmaster wrote:
> > > On Wed, Mar 22, 2023 at 12:24 AM David Engel 
> > > wrote:
> > > > 
> > > > Is this about sending MythTV logs to the database and not about
> > > > logging about database operations in MythTV?  If so, I have no
> > > > issues
> > > > with removing it either.
> > > 
> > > This is about logging *to* the database (the
> > > "logging" table)  It could allow MythTV to
> > > provide a centralized logging service, or
> > > supplementing (or replacing) syslog, file, or
> > > journald logging, and (as I recall) mythweb
> > > could even display it if so configured.
> > > 
> > > It has been set to disabled (by default)
> > > for a long time.
> > 
> > Thanks.  Proceed with your PR.  I see no reason to carry around a
> > reinvented wheel that isn't even being used.  There are better
> > alternatives available for those that really want searchable logs.
> 
> I'll take care of this.  There's a lot of cruft in there that could
> have been removed four years ago when the mythlogserver program was
> removed.
> 
> I just spent time removing the old qjsonwrapper external qt4->qt5 json
> bridge code.  Since that code was used as the connection from
> logging.cpp to loggingserver.cpp, that got me looking at all the
> unnecessary code in loggingserver.cpp.  (I.E. There's no need to
> convert an object to json and back if all the code executes in the same
> process, and there's no need for client->logger and logger->client maps
> if there's only ever one client.)  I punted on cleaning up that code
> four years ago, so now seems like a good time for me to finish the
> removal of the mythlogserver program.
> 
> David

I created the v34 release notes page and mentioned this (as in progress).
https://www.mythtv.org/wiki/Release_Notes_-_34#Special_Notices_.26_Instructions

-- 
Bill


More information about the mythtv-dev mailing list