[mythtv] config.h in dvdread

Gary Buhrmaster gary.buhrmaster at gmail.com
Fri Sep 23 03:10:46 UTC 2022


This is just a heads up of something that I encountered during some testing
that openSUSE seems to have a compile error with both master and fixes/32
if one has valgrind-devel installed.

  dvdread/dvd_input.c: In function ‘dvdinput_setup’:
  dvdread/dvd_input.c:292:36: error: ‘RTLD_LAZY’ undeclared (first use
in this function)
    292 |   dvdcss_library = dlopen(CSS_LIB, RTLD_LAZY);
        |                                    ^~~~~~~~~

It appears openSUSE ships a config.h in /usr/include/valgrind/
which is used (rather than the mythtv one) due to the include order

The quick fix (may not be the correct fix) appears to be:

for master:

diff --git a/mythtv/external/libmythdvdnav/dvdread/dvd_input.c
b/mythtv/external/libmythdvdnav/dvdread/dvd_input.c
index 1513182a59..a691366d48 100644
--- a/mythtv/external/libmythdvdnav/dvdread/dvd_input.c
+++ b/mythtv/external/libmythdvdnav/dvdread/dvd_input.c
@@ -19,7 +19,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */

-#include "config.h"                  /* Required for HAVE_DVDCSS_DVDCSS_H */
+#include "libmythbase/mythconfig.h"              /* Required for
HAVE_DVDCSS_DVDCSS_H */
 #include <stdio.h>                               /* fprintf */
 #include <stdlib.h>                              /* free */
 #include <fcntl.h>                               /* open */


for fixes/32:

diff --git a/mythtv/external/libmythdvdnav/dvdread/dvd_input.c
b/mythtv/external/libmythdvdnav/dvdread/dvd_input.c
index 1513182a59..08a5e4d2a5 100644
--- a/mythtv/external/libmythdvdnav/dvdread/dvd_input.c
+++ b/mythtv/external/libmythdvdnav/dvdread/dvd_input.c
@@ -19,7 +19,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */

-#include "config.h"                  /* Required for HAVE_DVDCSS_DVDCSS_H */
+#include "mythconfig.h"                          /* Required for
HAVE_DVDCSS_DVDCSS_H */
 #include <stdio.h>                               /* fprintf */
 #include <stdlib.h>                              /* free */
 #include <fcntl.h>                               /* open */




Thanks.


More information about the mythtv-dev mailing list