[mythtv] Compiler issue on github runner for Fixes/32 macOS 11/12

[John Hoyt]

On Wed, Nov 23, 2022 at 6:28 PM John Hoyt <john.hoyt at gmail.com> wrote:

> Hi Scott, thanks for taking a look.  I've worked up a patch file to
> resolve, but it sounds like getting configure working correctly is a better
> solution (happy to post the patch file).
>
>
>> Without the outputs from configure, particularly the log file config.ep,
>> I can't say for certain if those lines are the problem.
>>
>
> Configure output: https://pastebin.com/gG8E1Fbg
> config.ep: https://pastebin.com/b6Tk5M4Q
>

BTW - I can now reproduce on a local machine (wife's macbook) running
Monterey.  Strangely, all of my Ventura machines do not exhibit the
problem.

Here's the patch I worked up that successfully compiles:

diff --git a/mythtv/external/FFmpeg/libavutil/libm.h
b/mythtv/external/FFmpeg/libavutil/libm.h
index a819962391..71753deff5 100644
--- a/mythtv/external/FFmpeg/libavutil/libm.h
+++ b/mythtv/external/FFmpeg/libavutil/libm.h
@@ -427,21 +427,21 @@ static inline double rint(double x)
 #endif /* HAVE_RINT */

 #if !HAVE_LRINT
-static av_always_inline av_const long int lrint(double x)
+av_always_inline av_const long int lrint(double x)
 {
     return rint(x);
 }
 #endif /* HAVE_LRINT */

 #if !HAVE_LRINTF
-static av_always_inline av_const long int lrintf(float x)
+av_always_inline av_const long int lrintf(float x)
 {
     return (int)(rint(x));
 }
 #endif /* HAVE_LRINTF */

 #if !HAVE_ROUND
-static av_always_inline av_const double round(double x)
+av_always_inline av_const double round(double x)
 {
     return (x > 0) ? floor(x + 0.5) : ceil(x - 0.5);
 }
diff --git a/mythtv/libs/libmyth/audio/audioconvert.cpp
b/mythtv/libs/libmyth/audio/audioconvert.cpp
index 98a2e25c8c..1b7903e599 100644
--- a/mythtv/libs/libmyth/audio/audioconvert.cpp
+++ b/mythtv/libs/libmyth/audio/audioconvert.cpp
@@ -71,7 +71,7 @@ static inline bool sse_check()
 #endif //ARCH_x86

 #if !HAVE_LRINTF
-static av_always_inline av_const long int lrintf(float x)
+av_always_inline av_const long int lrintf(float x)
 {
     return (int)(rint(x));
 }
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-dev/attachments/20221123/6f540044/attachment.htm>