[mythtv] Call for testing branch devel/ffmpeg-resync (mpegts-harmonize)

Klaas de Waal klaas.de.waal at gmail.com
Fri Jul 29 13:35:51 UTC 2022


This is the commit that causes a failure on BBC streams with
the devel/ffmpeg-resync branch:

1bba2b59941d575ade7206d0ba52a556f5d3e672 is the first bad commit
commit 1bba2b59941d575ade7206d0ba52a556f5d3e672
Author: Scott Theisen <scott.the.elm at gmail.com>
Date:   Fri Mar 18 00:34:50 2022 -0400

The problem is not in the MHEG processing but in the presence of the
streams that contain the additional MHEG information.
With MHEG processing disabled it crashes in the same way.

Details:
- BBC streams received from Astra-2 satellite (a.k.a. Freesat).
- When playing a recording, the failure is on stopping playback.
- When using Live TV the failure is immediate, probably because Live TV
does a start / stop / start sequence when starting playback.

Could just be that your new reference counting code is not very good at
counting....

Hope this helps,
Klaas.








On Thu, 28 Jul 2022 at 01:45, Scott Theisen <scott.the.elm at gmail.com> wrote:

> On 7/27/22 17:20, John Pilkington wrote:
> > On 27/07/2022 19:14, John Pilkington wrote:
> >> On 27/07/2022 18:15, Scott Theisen wrote:
> >>> On 7/27/22 11:15, John Pilkington wrote:
> >>>> On 27/07/2022 14:20, John Pilkington wrote:
> >>>>
> >>>>> My apologies, but I'm having git problems again and ought to do
> >>>>> something else.  I created a local sub-branch for the earlier work
> >>>>> on frame counting, and it's getting in the way.
> >>>>
> >>>> I think that got fixed by deleting the contents of my repoB folder
> >>>> and recloning from repoA.  Now it would build the real current
> >>>> devel/ffmpeg-resync but git apply --check reports a patching error
> >>>> with what I extracted from your email.  Perhaps an attachment? Thanks.
> >>>>>
> >>>>>  > John
> >>>
> >>> I don't think my original patch would have worked correctly anyways.
> >>> Try the attached instead.
> >>>
> >>> If this correctly demuxes two DSMCC_B streams for your sample I will
> >>> consider this "working" even if you can't test the interactive TV
> >>> behavior versus master.
> >>>
> >>> Could you upload your sample somewhere so I can try to test it myself?
> >>>
> >>> Thanks,
> >>>
> >>> Scott
> >>
> >>
> https://drive.google.com/file/d/1Xm5dSJVRZj3BgGl38xPp6USGuQm2lzq_/view?usp=sharing
> >>
> > Attached is mythcommflag --resync log for the same BBC ONE newsclip using
> >
> >
> https://github.com/MythTV/mythtv/commit/d16fafb504110d12d55e698e12bf21c5aea7a082
> >
> >
> > with
> >
> > 0001-libavformat-mpegts-mythtv.c-reuse-existing-DSMCC_B-s.patch
> >
> > Quitting playback of this clip no longer causes a crash.
> >
> > Thanks and regards,
> >
> > John
>
> Thanks for testing and the sample.  Unfortunately, I appear to have
> broken MHEG, so I'll need to fix that with the help of your sample.
>
> Regards,
>
> Scott
>
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://lists.mythtv.org/mailman/listinfo/mythtv-dev
> http://wiki.mythtv.org/Mailing_List_etiquette
> MythTV Forums: https://forum.mythtv.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-dev/attachments/20220729/ab0d8e50/attachment.htm>


More information about the mythtv-dev mailing list