[mythtv] [mythtv-commits] [MythTV/mythtv] cbcffc: Jump back in live TV

[David Engel]

On Wed, Apr 27, 2022 at 02:43:49PM -0700, kmdewaal via mythtv-commits wrote:
>   Branch: refs/heads/master
>   Home:   https://github.com/MythTV/mythtv
>   Commit: cbcffc474df6f79779ac5af5f0a9a91e34cfad39
>       https://github.com/MythTV/mythtv/commit/cbcffc474df6f79779ac5af5f0a9a91e34cfad39
>   Author: Klaas de Waal <klaas at kldo.nl>
>   Date:   2022-04-27 (Wed, 27 Apr 2022)
> 
>   Changed paths:
>     M mythtv/libs/libmythtv/mythplayer.cpp
> 
>   Log Message:
>   -----------
>   Jump back in live TV
> 
> When jumping back in live TV and the jump time interval is larger than the
> current play position then a jump is done to the end of the recording instead
> of to the start of the recording.
> Fixed by restoring a cast that was accidentally removed in
> commit 7949b0d20b5dc1b63c88ef511ccbef18c71ec8bf.

Klaas,

Thanks for finding and fixing this issue.  My mom uses live TV a lot
and this bug occasionally crops up.  However, there is at least one
other, similar bug still there.  I don't know if it's related to your
fix or is pre-existing.

If playback is at the end of an earlier program in the live TV chain,
skipping forward jumps to the same relative time in the next program
instead of to the beginning of the next program.  For example, let's
say the user watches program A for 10 minutes and then switches to
program B and watches for 20 minutes.  If the user then goes back to
near the end of program A and skips forward, playback of program B
picks up at the 10 minute mark instead of at the beginning.  If
program B is shorter than program A, playback picks up at the end of
program B.

If you can't/won't look into this, that's fine.  It's not necessarily
high on my TODO list either.  If you do look into it, however, and
you're really, really motivated, there is another, long-standing
mis-feature that is probably also related to these.  That is that
fast-forward/rewind stops when it hits a program boundary.  It would
be nice if ff/rew continues across those boundaries.

David
-- 
David Engel
david at istwok.net