[mythtv] compile issues - latest macOS SDK (11.3) / Xcode (12.5)

[David Hampton]

On Sun, 2021-05-30 at 09:02 -0400, John Hoyt wrote:
> First - apologies, this is occurring on Xcode 12.5 (latest release)-
> error in my original email.  I have corrected the subject line and
> confirmed this to be a non-issue with Xcode 12.4 and earlier.
>  
> > It seems to me that renaming VERSION to something new may be the
> > simplest solution.
> > 
> 
> 
> I've put together a fork on github for master and fixes/31 that
> renames VERSION to SRC_VERSION and updates version.sh accordingly
> here: https://github.com/jhoyt4/mythtv 
> 
> I have confirmed that these updates compile successfully on macOS.
> 
> If this is an acceptable solution by the community, I'll issue a PR
> for both master and fixes/31 and link them to my issue report.  Also
> happy to have another set of eyes look at the update in case I missed
> something.

Looks good to me.

> If this is not an acceptable solution, no big deal - I will happily
> delete the fork.  Honestly, I'm just looking for some help / feedback
> on alternative solutions if the simple rename is not palatable. 
> After investigating my compile script, the -l"../.." is NOT passed in
> by the script but somewhere else by default in the codebase.   This
> could be addressed via that route, but I'll need some pointers on
> where to look.

Its coming from external/libmythsoundtouch/libmythsoundtouch.pro:

  INCLUDEPATH += . ../../

It seems like you should be able to rewrite this as

  INCLUDEPATH += $$(PWD) $$(PWD)/../../

to get absolute paths, but its not that simple. (I tried.) QMake is
apparently doing path manipulation (and deduplication?) behind the
scenes, and still insists on including something that starts with ../..
instead of using fully rooted paths. (Weirdly, the ../.. from before
ends up as ../../../mythtv.) Besides, this doesn't solve the problem of
finding "version" in the system include path before finding "VERSION"
in the user include path.

If no-one else has any objection, I can commit your changes.

David