[mythtv] ATSC scan, default channel number

[John P Poet]

On Tue, Jul 13, 2021 at 11:36 AM Klaas de Waal <klaas.de.waal at gmail.com>
wrote:

>
>
> On Sat, 10 Jul 2021 at 17:44, John P Poet <jppoet at gmail.com> wrote:
>
>> On Sat, Jul 10, 2021 at 7:30 AM Klaas de Waal <klaas.de.waal at gmail.com>
>> wrote:
>>
>>>
>>>
>>> On Sat, 10 Jul 2021 at 10:32, Klaas de Waal <klaas.de.waal at gmail.com>
>>> wrote:
>>>
>>>>
>>>>
>>>> On Fri, 9 Jul 2021 at 22:57, John P Poet <jppoet at gmail.com> wrote:
>>>>
>>>>> Hi Klaas,
>>>>>
>>>>> I am setting up a new development machine to do some work. In the
>>>>> process I noticed that when scanning ATSC channels, no default channel
>>>>> number is given and the user must manually choose one for every single
>>>>> channel. This is when the user chooses to manually pick which channels get
>>>>> inserted into the DB.
>>>>>
>>>>> For example, the message I am getting is:
>>>>>
>>>>>> You chose to manually insert channel 7_1 (KOAT-DT). Please enter a
>>>>>> unique channel channel number. Default value is
>>>>>>
>>>>>
>>>>> If I just click on OK, it just redraws the same dialog box. Instead I
>>>>> have to select Edit and type in 7_1. I could have sworn this was more
>>>>> automatic the last time I did this. Any chance you can have it pick a good
>>>>> default?
>>>>>
>>>>> Hi John,
>>>>
>>>> This definitely should be automatic so there is something really wrong.
>>>> The correct behavior is to use the received channel number without
>>>> asking and when there is a conflict the suggestion channel number is with a
>>>> letter added.
>>>> There should also be the option in the dialog for "OK for all"  so that
>>>> it is never asked again.
>>>> It could be a coincidence but there are also threads in the forum about
>>>> ATSC cable scanning not working at all or crashing once the scan is
>>>> complete. And that is with v31. I assume you are using master.
>>>> At least you still get the correct channel numbers and names, which the
>>>> ATSC cable scans do not even do anymore.
>>>> What makes this a puzzle is that I have not changed anything
>>>> significant in the scanning code for a long time now.
>>>> On the other hand, maybe people do not do channel scans that often....
>>>> The scanning does work correctly with DVB-T2/C/S2 as you might have
>>>> guessed.
>>>> I will have a look at the code this weekend and possibly try to do a
>>>> simple ATSC scan with a captured ATSC transport stream. Have done that in
>>>> the past so I should be able to do that again....
>>>> In the meantime, if you have an idea what is wrong be welcome to
>>>> explore and fix it!
>>>>
>>>> Hi John,
>>>
>>> Can you please send me a complete backup of your database after you have
>>> done one or more scans?
>>> Rationale:
>>> In master the "Scan type"  "Import Existing Scan" allows playing back
>>> again a scan previously done. I expect the bug to be in the channel
>>> importer where the options such as "Complete scan data required" etc are
>>> processed and this can be replayed from an existing scan. Which then
>>> hopefully enables me to debug the channel numbering code with your ATSC
>>> scan.
>>>
>>> Thanks,
>>> Klaas.
>>>
>>
>> Yes, I can do that. I will replicate what I did when I saw the problem,
>> which was to do a scan on an initial setup, i.e. brand new database.
>>
>>
>> Hi John,
>
> I've resurrected the capability to scan from a single transport stream,
> according to your description in
>
> https://github.com/MythTV/mythtv/commit/8828cc5e4698f72e25fcfc31782c42fda5079717#diff-09ba904030e3795f57e6332cba578167
> "Add the ability to scan for the programs in a MPTS stream from an IPTV
> source."
> I needed a small fix in channelscan_sm.cpp to make this work but that is
> another story.
> The good news is that I should now be able to reproduce and debug the
> channel importer issue.
>
> Question: can you send me a full MPTS that does not scan correctly?
>
> Thanks,
> Klaas.
>

Hi Klaas,

Yes, I can do that. It may take me a couple of days, but I will get it to
you by the end of this week.

John
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-dev/attachments/20210713/bfba1e1c/attachment.htm>