[mythtv] Picture in Picture broken

[Mark Kendall]

On Wed, 11 Mar 2020 at 20:11, Klaas de Waal <klaas.de.waal at gmail.com> wrote:

> Here the PIP/main window exchange always hangs. Repeat: lock on all attempts to exchange.
> From this I have made a gdb backtrace which is attached.

OK - plan A is not going to work.

The more I looked at the threading issues, the more problems I saw and
the more deadlocks I could trigger... and no amount of tweaking will
fix it.

So onto plan B.

I've disabled PiP in v31, reverted some of the attempts to fix the
deadlocks and started to sanitise some of the locking in the decoder
classes.

I have 2 more patches, that will probably go in tomorrow morning, that
factor out the most significant global, static locks in the codebase.

While I am pretty comfortable with these patches and they are not at
face value too complicated, they do make some fundamental changes to
decoding of ALL media - not just PiP.

So volunteers welcome for some heavy duty testing in the next few days
- otherwise the code is unlikely to make v31.

Regards
Mark