[mythtv] [mythtv-commits] [MythTV/mythtv] 3c460f: Variable name change in ServiceDescriptorMapping

[Klaas de Waal]

Could be, but there is existing MythTV DVB code that uses this style
for the private data and I just follow the examples here. Look for
instance at dvbstreamdata.h. Also, the item is called service_type in
the DVB spec.

Klaas.

On Sat, 7 Dec 2019 at 16:07, Paul Harrison <mythtv at mythqml.net> wrote:
>
>
> On 07/12/2019 14:33, kmdewaal wrote:
> >   Branch: refs/heads/master
> >   Home:   https://github.com/MythTV/mythtv
> >   Commit: 3c460f2496fbaac04aeee6968134b3104e0ffb05
> >       https://github.com/MythTV/mythtv/commit/3c460f2496fbaac04aeee6968134b3104e0ffb05
> >   Author: Klaas de Waal <kdewaal at mythtv.org>
> >   Date:   2019-12-07 (Sat, 07 Dec 2019)
> >
> >   Changed paths:
> >     M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
> >
> >   Log Message:
> >   -----------
> >   Variable name change in ServiceDescriptorMapping
> >
> > Change variable m_serviceid to m_service_type to
> > prevent possible confusion about what is stored here.
> >
> >
>
> Shouldn't that be m_serviceType to match our coding standards?
>
>
> --
>
> Paul H.
>
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://lists.mythtv.org/mailman/listinfo/mythtv-dev
> http://wiki.mythtv.org/Mailing_List_etiquette
> MythTV Forums: https://forum.mythtv.org