[mythtv] ef1893f99 causing compilation failure on macos

[David Hampton]

On September 10, 2018 3:33:09 AM PDT, Piotr Oniszczuk <piotr.oniszczuk at gmail.com> wrote:
>David,
>
>
>> 
>> I've been looking at the source code. Try editing
>mythplugins/mythmusic/mythmusic/playlist.h and moving the #endif from
>line 119 down five lines to just after the declaration of
>processExit(). See if that fixes the compile error.
>> 
>
>above change helps :-)
>
>
>BTW:
>
>I have another compile blocker on macOS:
>it is:
>https://github.com/MythTV/mythtv/commit/83f60130703cdc62075c8737dcae531e00b4f341#diff-e19b96320cb762776ea87e2840d2df78
>
>
>compile error is following:
>
>ccache
>/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++
>-c -pipe -stdlib=libc++ -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
>-DPIC -isysroot
>/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk
>-mmacosx-version-min=10.9
>-I/Users/piotro/Devel/mythtv-master/.osx-packager/build/include
>-I/Users/piotro/Devel/mythtv-master/.osx-packager/build/mysql
>-std=c++11 -DNDEBUG -fomit-frame-pointer -fPIC
>-DQT_DISABLE_DEPRECATED_BEFORE=0x050200 -msse -pthread -g -Wall -Wextra
>-Wpointer-arith -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS
>-Wno-constant-logical-operand -Wno-unused-value -Qunused-arguments
>-Wimplicit-fallthrough -std=gnu++11  -arch x86_64 -isysroot
>/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk
>-mmacosx-version-min=10.11 -fPIC -DMMX -DUSING_APPLEREMOTE
>-D_GNU_SOURCE -DMYTH_API -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB
>-DQT_NETWORK_LIB -DQT_XM
>L_LIB -DQT_SQL_LIB -DQT_SCRIPT_LIB -DQT_DBUS_LIB -DQT_CORE_LIB -I.
>-I../../external/libmythsoundtouch -I../libmythfreesurround
>-I../libmythbase -I../.. -I.. -I. -I../libmythupnp -I../libmythui
>-I../.. -I../../external/FFmpeg -I../libmythservicecontracts
>-I/Users/piotro/Devel/Qt5.11.1SDK/5.11.1/clang_64/lib/QtWidgets.framework/Headers
>-I/Users/piotro/Devel/Qt5.11.1SDK/5.11.1/clang_64/lib/QtGui.framework/Headers
>-I/Users/piotro/Devel/Qt5.11.1SDK/5.11.1/clang_64/lib/QtNetwork.framework/Headers
>-I/Users/piotro/Devel/Qt5.11.1SDK/5.11.1/clang_64/lib/QtXml.framework/Headers
>-I/Users/piotro/Devel/Qt5.11.1SDK/5.11.1/clang_64/lib/QtSql.framework/Headers
>-I/Users/piotro/Devel/Qt5.11.1SDK/5.11.1/clang_64/lib/QtScript.framework/Headers
>-I/Users/piotro/Devel/Qt5.11.1SDK/5.11.1/clang_64/lib/QtDBus.framework/Headers
>-I/Users/piotro/Devel/Qt5.11.1SDK/5.11.1/clang_64/lib/QtCore.framework/Headers
>-Imoc
>-I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sd
>k/System/Library/Frameworks/OpenGL.framework/Headers
>-I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/AGL.framework/Headers
>-I/Users/piotro/Devel/Qt5.11.1SDK/5.11.1/clang_64/mkspecs/macx-clang
>-F/Users/piotro/Devel/Qt5.11.1SDK/5.11.1/clang_64/lib -o
>obj/moc_mythcontext.o moc/moc_mythcontext.cpp
>audio/audiooutputca.cpp:207:21: error: expected ')'
>        while ((int rate = settings->GetNextRate()))
>                    ^
>audio/audiooutputca.cpp:207:16: note: to match this '('
>        while ((int rate = settings->GetNextRate()))
>               ^
>audio/audiooutputca.cpp:207:52: error: expected expression
>        while ((int rate = settings->GetNextRate()))
>                                                   ^
>audio/audiooutputca.cpp:212:49: error: use of undeclared identifier
>'rate'
>                                if (*p_rates == rate)

There is an extra set of parentheses on line 207. Removing those should allow your compilation to continue. 

David