[mythtv] Key mapping for BOOKMARK

[Peter Bennett]

On 03/15/2018 12:12 PM, Michael T. Dean wrote:
> On 03/15/2018 11:06 AM, Lennart Sorensen wrote:
>> On Thu, Mar 15, 2018 at 08:10:40AM -0400, Michael T. Dean wrote:
>>> ...our approach in the past has generally been to not provide a 
>>> default key
>>> binding for any new actions added to MythTV because the chosen 
>>> key(s) may
>>> conflict with a user-mapped binding.  See
>>> https://lists.gt.net/mythtv/dev/266100#266100 .  Based on the 
>>> responses in
>>> this thread--suggesting few people use SELECT to set a bookmark--I 
>>> would
>>> consider this to be a not significant case. Therefore, having an empty
>>> default keylist for SET_BOOKMARK and for TOGGLE_BOOKMARK would make 
>>> sense
>>> since there are other approaches by which the user can set a 
>>> bookmark (even
>>> by just exiting playback).
>> I hate the on exit option and have it off.  I only use the hitting space
>> or enter key method.
>
Hi Mike

I am digesting your longer reply to my original email, and it all makes 
sense. While thinking about a response I came up with another idea that 
could be much easier and have less impact.

Let the SELECT keys still operate the bookmarks in the way they always 
have, in conjunction with the AltClearSavedPosition setting. Add the 
TOGGLE_BOOKMARK and SET_BOOKMARK actions, unassigned to any keys. In the 
code, support SELECT and the two new actions. The existing functionality 
will not be changed at all. People who want to use the enter key for 
pause or other things can map the keys in playback context. They will be 
able to map bookmarks to other keys if they still want to use bookmarks.

I see there is some precedent for this, in the manual zoom code, where 
you can assign ZOOM actions but also it uses default actions in the code 
if a key is used that is not mapped to a zoom action (e.g. left and right).

I am also adding set bookmark and jump to bookmark to the playback 
navigation menu.

Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-dev/attachments/20180315/cd194218/attachment.html>