[mythtv] Ticket #12809: Use lastPlayPos rather than bookmark

[Roger Siddons]

On Wed, 10 Jan 2018 13:07:40 -0500
Peter Bennett <pb.mythtv at gmail.com> wrote:

> On 12/27/2017 06:05 PM, Roger Siddons wrote:
> > On Wed, 27 Dec 2017 17:58:52 -0000
> > "MythTV"<noreply at mythtv.org>  wrote:
> >  
> >> #12809: Use lastPlayPos rather than bookmark
> >> -------------------------------------+-----------------------------
> >>   Reporter:  rsiddons                 |          Owner:  rsiddons
> >>       Type:  Patch - Feature          |         Status:  assigned
> >>   Priority:  minor                    |      Milestone:  29.1
> >> Component:  MythTV - Video Playback  |        Version:  Master Head
> >>   Severity:  low                      |     Resolution:
> >>   Keywords:                           |  Ticket locked:  0
> >> -------------------------------------+-----------------------------
> >>
> Hi Roger
> 
> The old patch you provided for the services - I have it working but I 
> think it needs some more features. It only allows getting the marks,
> not setting them. Kodi would also need to set the last played
> position so I plan to add a set method for the 4 values: Bookmark,
> Duration, Progstart, LastPlay. I don't know if you think allowing
> setting of Duration or Progstart lets people shoot themselves in the
> foot. Is there some consensus on what we should allow setting? Maybe
> it should only set Bookmark and LastPlay?
> 

Thanks for that Peter. SoapUI sounds useful.

I can't imagine a valid reason for a client to overwrite the duration,
so I think it should be excluded/ignored.

ProgStart is just a 'best guess' from the recorder, so I think a client
should be able to correct that (probably via user/cutlist editor).

> Also I think the service should allow getting and setting using
> channel and start time as well as by recordid. I will add those
> options.

I believe not. Many services were created when Chan/time was *the*
id of a recording and they had to be preserved when the *main*
id becrecordedId was added later. For new services it's not required -
recId is/should always be available.