[mythtv] [mythtv-commits] mythtv branch master updated by gigem. v30-Pre-42-gd2d92b2

[Mike Bibbings]

On 17/09/17 01:14, David Engel wrote:
> On Sat, Sep 16, 2017 at 11:30:04PM +0000, John P Poet wrote:
>> On Sat, Sep 16, 2017 at 3:03 PM John P Poet <jppoet at gmail.com> wrote:
>>
>>> On Thu, Sep 14, 2017 at 7:11 PM, Git Repo Owner <noreply at mythtv.org>
>>> wrote:
>>>
>>>> The branch, master has been updated on the
>>>> mythtv repository by gitolite user gigem.
>>>>         via  d2d92b2d34c08db5092c0ee0e5b432efa7c58f97 (commit)
>>>>         via  e82386cbced67f5f0e36d36be833b162f9847299 (commit)
>>>>        from  39c9292fdc9385dbee25faf5bca8ca6b1d67b31b (commit)
>>>>
>>>> Those revisions listed above that are new to this repository have
>>>> not appeared on any other notification email; so we list those
>>>> revisions in full, below.
>>>>
>>>> - Log -----------------------------------------------------------------
>>>> commit d2d92b2d34c08db5092c0ee0e5b432efa7c58f97
>>>> Author:    David Engel <dengel at mythtv.org> at Thu, 14 Sep 2017 20:03:21
>>>> -0500
>>>> Committer: David Engel <dengel at mythtv.org> at Thu, 14 Sep 2017 20:03:21
>>>> -0500
>>>> URL:
>>>> http://code.mythtv.org/cgit/mythtv/commit/?id=d2d92b2d34c08db5092c0ee0e5b432efa7c58f97
>>>>
>>>> Remove QueryInputDisplayName/kUnknownInputName nonsense.
>>>> As I remember it, when inputname was added to ProgramInfo, we didn't
>>>> want to further bloat the Myth protocol by passing it around too.
>>>> Instead, we made provisions to load it on demand from the database.
>>>> Later, someone else realized lots of database queries were happening
>>>> to get the inputname and slowing things down, so they added inputname
>>>> to the protocol.  This change [hopefully] makes sure inputname
>>>> initially gets set everywhere it should and removes all vestiges of
>>>> the load on demand support.
>>>>
>>>>
>>>>
>>>> commit e82386cbced67f5f0e36d36be833b162f9847299
>>>> Author:    David Engel <dengel at mythtv.org> at Thu, 14 Sep 2017 13:39:24
>>>> -0500
>>>> Committer: David Engel <dengel at mythtv.org> at Thu, 14 Sep 2017 20:02:07
>>>> -0500
>>>> URL:
>>>> http://code.mythtv.org/cgit/mythtv/commit/?id=e82386cbced67f5f0e36d36be833b162f9847299
>>>>
>>>> Enhance RecStatus::toString() to allow a replacement string.
>>>> A future change will allow use of a shortened inputname instead of
>>>> just the numberic inputid.
>>>>
>>>>
>>>>
>>>> -----------------------------------------------------------------------
>>>>
>>>> Summary of changes:
>>>>   mythtv/libs/libmyth/programinfo.cpp                |   75
>>>> +++-----------------
>>>>   mythtv/libs/libmyth/programinfo.h                  |    3 +-
>>>>   mythtv/libs/libmythbase/mythversion.h              |    2 +-
>>>>   .../libmythservicecontracts/enums/recStatus.cpp    |   16 +++--
>>>>   .../libs/libmythservicecontracts/enums/recStatus.h |    1 +
>>>>   mythtv/libs/libmythtv/recordinginfo.cpp            |    9 ++-
>>>>   mythtv/libs/libmythtv/recordinginfo.h              |    3 +-
>>>>   mythtv/programs/mythbackend/scheduler.cpp          |   13 +++-
>>>>   mythtv/programs/mythfrontend/progdetails.cpp       |    2 +-
>>>>   9 files changed, 41 insertions(+), 83 deletions(-)
>>>>
>>>> --
>>>
>>> Hi David,
>>>
>>> Commit d2d92b2d34c08db5092c0ee0e5b432efa7c58f97 breaks the Steppes
>>> theme.  In the "Upcoming Recordings" screen, it is supposed to show the
>>> name of the input that will be used.  Starting with this commit, it just
>>> shows a tilde (~) instead.
>>>
>> Actually, it breaks all themes.  In "Upcoming Recordings", hit (I)nfo twice
>> and the "Recording Input" is now showing as a tilde.
> It certainly didn't do that for me when I tested it.  I will test it
> again, but can't do so right now.  My dev system shares some normally
> unused, networked tuners with my production system, but they are busy
> right now.
>
> In the meantime, can you try a distclean and rebuild?  That tilde
> business is exactly what I removed.  Maybe something didn't get
> rebuilt when in should have.
>
> David

This is just for information.

I am running built from source on Lubuntu 16.04, 30-pre 211b8da (latest 
as of writing) with Steppes 2.32

I am not seeing any problems.

I have always used Display Name when setting up mythbackend, so it shows 
me the tuner e.g. quad-1 , but not which input within the tuner (Max 
Recordings is set to 10).

As a test I reset the Display name  to nothing using mythtv-setup, and 
it now shows Input 1, Input 2 etc

Mike