[mythtv] Problem with commit 9506b88 2017/10/09 : Cleanup gcc and clang warnings generated by -Wextra switch.

[Jonatan Lindblad]

Den 2017-10-25 kl. 04:38, skrev Peter Bennett:
> Hi David
> 
> The above mentioned commit is a merge of hundreds of changes. It is causing memory corruption errors on Raspberry Pi, consistently every time you try to play a recording. You get one of these errors and a core dump:
> 
> corrupted size vs prev size
> smallbin double link list corrupted
> free(): invalid pointer
> 
> These occur in malloc and free at different places each time. AMD64 systems are not affected although the codebase is the same.
> 
> Compiling from aea96ba which is the immediately prior commit, is fine.
> Compiling from 9506b88 which is immediately after that commit, gives those errors, as does compiling from the latest.
> 
> I cannot compile any of the intermediate commits between those two, because they are off your repository, do not contain the Raspberry Pi Stretch changes, and thus fail compilation.

They certainly are in the repository, the merge pulled them all in.

$ git show 9506b88
commit 9506b88b3bc2c3717b32102ece45794fa71f791b
Merge: 594b16057b 6ee77bc064
Author: David Hampton <snip>

$ git merge-base 594b16057b 6ee77bc064
693bc46ce5e665e04ac2dad9975d45a45be196e0

$ git log --oneline 693bc46ce5e665e04ac2dad9975d45a45be196e0..6ee77bc064
6ee77bc064 Use local variable to prevent warning messages.
45c22fd783 Conditionally compile out unfinished code.
334dc5fe84 Fix 'address of array will always evaluate to true' warning.
ffaa099751 Fix "using directive refers to implicitly-defined namespace 'std'" warning.
0dbe67eacf Fix 'comparison of integers of different signs' warning message.
db88d597d5 Fix 'max of value and unsigned zero' warning message.
869832702c Fix 'implicit conversion changes value' warning message.
8e5fcd3de8 Conditionally compile out the unused RequestRange function.
1e4b5fb394 Move an unused InfoMap printing function to a different file.
...

Cheers
Jonatan