[mythtv] Inconsistent star ratings

[Jan Schneider]

Zitat von Jan Schneider <jan at horde.org>:

> Zitat von Michael T. Dean <mtdean at thirdcontact.com>:
>
>> On 01/23/2017 11:01 AM, Jan Schneider wrote:
>>>
>>> Zitat von Jan Schneider <jan at horde.org>:
>>>
>>>> Hi,
>>>>
>>>> I'm wondering if there is some (technical or other) reason for  
>>>> the UI inconsistencies regarding star ratings.
>>>>
>>>> My EPG grabber supports 4 stars only which is returned correctly  
>>>> by XMLTV and used and calculated correctly in MythTV, and stored  
>>>> as a float between 0 and 1. BUT the presentation is inconsistent  
>>>> which makes this feature very unrelying for non-tech users. The  
>>>> different ratings I get are:
>>>> - Recording list: 1-10
>>>> - Recoding or EPG details: 1-4
>>>> - mythweb: 1-5
>>>>
>>>> Jan.
>>>
>>> Oh, and btw. is there some reason that this is a FLOAT, and not a  
>>> DECIMAL field? This makes comparisons more complicated than  
>>> necessary.
>>
>> Some background. I think the idea was to use a value that could  
>> then be applied to whatever base we chose:
>>
>> https://code.mythtv.org/trac/ticket/7810#comment:1
>>
>> and the rest of the thread.
>
> So this sounds like 1-10 is what should be used, and 1-5 is probably  
> mythweb's fault, while 1-4 might be the theme's (or themes' - I've  
> seen this in at least two themes) fault.

I stand corrected, this is not the themes' fault, they use YEARSTARS  
which is propagated at ProgramInfo::ToMap(). So there IS some  
inconsistency inside core Myth.

-- 
Jan Schneider
The Horde Project
https://www.horde.org/