[mythtv] [mythtv-commits] Ticket #12989: Feature patch: Use XMLTV dd_progid data to create seriesid

[John P Poet]

On Sun, Feb 19, 2017 at 8:20 AM Peter Bennett <pgbennett at comcast.net> wrote:

>
>
> On 02/18/2017 04:10 PM, MythTV wrote:
> > #12989: Feature patch: Use XMLTV dd_progid data to create seriesid
> >
> -------------------------------------------------+-------------------------
> >   Reporter:  Gary Buhrmaster <gary.buhrmaster@…>  |          Owner:
> stuartm
> >       Type:  Patch - Feature                      |         Status:  new
> >   Priority:  minor                                |      Milestone:
> unknown
> > Component:  MythTV - Mythfilldatabase            |        Version:
> Master
> >                                                   |  Head
> >   Severity:  medium                               |     Resolution:
> >   Keywords:                                       |  Ticket locked:  0
> >
> -------------------------------------------------+-------------------------
> >
> > Comment (by jpoet):
> >
> >   The first part of this has been committed in [4e5cf2b4ef].
> >
> >   I am unsure about the second part.  I would be fine for me, but I don't
> >   know how it would affect non-US users.  Stuart, Karl, do you have
> >   thoughts?
> >
> > --
> > Ticket URL: <https://code.mythtv.org/trac/ticket/12989#comment:1>
> > MythTV <http://www.mythtv.org>
> > MythTV Media Center
> > _______________________________________________
> > mythtv-commits mailing list
> > mythtv-commits at mythtv.org
> > http://lists.mythtv.org/mailman/listinfo/mythtv-commits
>
> Gary
>
> As one of the "(very very?) few that were using Schedules Direct data
> using the internal DD grabber and moved to using the XMLTV grabber", I
> would like to understand this.
>
> When I moved from the internal DD grabber to the XMLTV grabber
> (tv_grab_zz_sdjson_sqlite), I did not notice any problem. If it was
> using a different series id I would think that programs previously
> scheduled would start being scheduled for recording again (there are
> hundreds of reruns every week and I do not use the "new programs only"
> flag). I thought it used the series id for matching previously recorded?
>
> If I apply your new changes (without running the xml update), will I
> notice previously recorded programs being re-recorded?
>
> I struggle to understand why the situation is different for those who
> moved from DD to XMLTV to the new patch, and those who just move from DD
> to the new patch.
>
> I have removed series id from all recording rules after having some
> missed recordings.
>
> Peter
>

Hi Peter,

I did not notice any problems at first either, when I moved from the DD
grabber to tv_grab_zz_sdjson_sqlite.  However, I started noticing issues
with recording rules that had a "this series" filter.  I first noticed the
problem when I setup a recording rule for the "Lethal Weapon" series and
ended up recording the movie as well.

I reached out to Gary for help, and he explained that the xmltv importer
crafted the Series Id based on the show title, etc, instead of using the
Program Id.  With this explanation, I crafted a quick patch which fixed the
problem for me.  I let Gary know that crafting the Series Id from the
Program Id fixed it, and he came up with a more complete patch which
mimicked the behavior of the DD grabber.

If you want to see an example of the problem, try recording "Taboo" off of
FX.  Without this patch, you will also end up recording "Taboo" off of NGC,
even if you set the "This series" filter.

John
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-dev/attachments/20170219/1e4f8d02/attachment.html>