[mythtv] Ticket #12709: Segmentation fault playing a recording with file missing
pgbennett at comcast.net
Wed Apr 6 23:12:02 UTC 2016
On 04/06/2016 05:35 PM, MythTV wrote:
> Now I see that #12693 would have prevented the original crash (but not on
> a Pi). This one looks like it solves it on the Pi too, but isn't
> isOpenMaxRender == true when NOT using openmax ?
You are right. The logic is correct, the field name is wrong. Although
it is working correctly I really should change it - it does not make
sense with the field named that way and meaning the opposite of its name.
> IMO the dynamic cast is convoluted. Why not create your virtual !GetName()
> ? It could default to an empty string and only needs to be overridden by
> videoout_omx. It may become useful for someone else later...
That was my first preference. I looked carefully for an existing virtual
method that would work but found none. The trouble with that is if it is
a pure virtual method I would need to add it to all VideoOutput
subclasses, which makes for a lot of changes. The other alternative is
not have it as pure and let it return a null by default until it is
implemented in all VideoOutput subclasses.
Please let me know what your preference is. If you prefer me to create a
virtual GetName() I will do that. Would you like me to add it to all
VideoOutput subclasses as well, or just leave it as defaulting to null
until they are changed? If I add it to all I will make it pure virtual
so as to enforce its use in future classes.
More information about the mythtv-dev